From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4B3C4456B7 for ; Mon, 20 Mar 2023 22:35:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7812B68C592; Tue, 21 Mar 2023 00:35:49 +0200 (EET) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A1B068C3D6 for ; Tue, 21 Mar 2023 00:35:42 +0200 (EET) Received: by mail-wr1-f43.google.com with SMTP id r29so11887616wra.13 for ; Mon, 20 Mar 2023 15:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679351741; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=kSw6Cy4pEx2FOSgJoqJcu+AJjoT+A+H4276nfo7pKM0=; b=WEK6cFgxmWtn3Ra1TMQw7drBbc3chim32AfhLYrSg+VJjOKRL/0DN3hZKYZsuDgdtH pkv0vQir7J3HW8hdDV3jkkEB2yj1hEYN+iupIHm7MIu7kxTTxiR1nsP+kNkz6BDf4owX aJZcLReFCgfWe2az+zbPlUkhA8sxq5L/UgUY4aijBnJVhwmLUBoecd/L8LvwaqGqH5OI lYZLR9/2FbjiI4XvQ7RtTKq9zmYG0EGMXPxq181ge6lGyhmqKWJIOHGSUXwIw5z4CE5Q 9xNJJZ6IVgK84RwTWbQulhG/4hqPAHGf6vWvQWCaU9wMOAA4QivBAipKcjOEUPLHEnhu gnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679351741; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kSw6Cy4pEx2FOSgJoqJcu+AJjoT+A+H4276nfo7pKM0=; b=P/4fr35QBlk5Zgi74fnm3xCtvlbqWCEqO01Xja7y9DQmpIXqQios1gWE0cXQKu/68Y 7OJ9S5+7iiTZT9OXOms/6FqYYXP2bculPKteYwmd3vOmwFe62XP92rFdUKypLqYTc8C1 iWZnEXcte82UeTDf8qiDY87y8Bz7bpSlUUDmCQ5wRzrvCyudxdUfeWW2sm4yYNEeuF6B I/LzYgCyIW/s0v8d6Gpxi89akz4zE3lKmcXqpz5EPtIMuZ2Dv8K+RHC2ICmxbLeo4Yif 0PyLmz0sLoF+cD6thJXOap5W3zTAGqAsO9X5LmBwRZYwgtgTq0Y+b4IipA+YQoJ4RjED cwfw== X-Gm-Message-State: AO0yUKWcLSlzryJWHbs/RYTH8s8w84iyIr1Y8AU+/LZ+OMRgoJVr0GpE 6fn6yaAEYHTeY7fmwDd9mtrNEqnI3mPO6Q== X-Google-Smtp-Source: AK7set8W4k/QaTpEWgttmnSElmsWM38IqmDesOXuwlspWUrHDzlhMBa/1oEbTzM6agFAa1LWAXTP/Q== X-Received: by 2002:a05:6000:137b:b0:2cf:e34c:a229 with SMTP id q27-20020a056000137b00b002cfe34ca229mr649525wrz.8.1679351741097; Mon, 20 Mar 2023 15:35:41 -0700 (PDT) Received: from mariano (dynamic-adsl-62-10-98-143.clienti.tiscali.it. [62.10.98.143]) by smtp.gmail.com with ESMTPSA id a17-20020a5d5091000000b002c7b229b1basm9852464wrt.15.2023.03.20.15.35.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 15:35:40 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id DF50FBFB73; Mon, 20 Mar 2023 23:35:39 +0100 (CET) Date: Mon, 20 Mar 2023 23:35:39 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230320223539.GJ48946@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230315183037.74862-1-thilo.borgmann@mail.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230315183037.74862-1-thilo.borgmann@mail.de> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Use all metadata selectors if none is specified. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2023-03-15 19:30:37 +0100, Thilo Borgmann wrote: > Fixes regression from 3c7dd5ed37da6d2de06c4850de5a319ca9cdd47f. > Fixes ticket #10157. > --- > fftools/ffmpeg_mux_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c > index b3cc502fdd..deb09666bb 100644 > --- a/fftools/ffmpeg_mux_init.c > +++ b/fftools/ffmpeg_mux_init.c > @@ -1819,11 +1819,11 @@ static int copy_metadata(Muxer *mux, AVFormatContext *ic, > parse_meta_type(mux, inspec, &type_in, &idx_in, &istream_spec); > parse_meta_type(mux, outspec, &type_out, &idx_out, &ostream_spec); > > - if (type_in == 'g' || type_out == 'g') > + if (type_in == 'g' || type_out == 'g' || !*outspec) > *metadata_global_manual = 1; > - if (type_in == 's' || type_out == 's') > + if (type_in == 's' || type_out == 's' || !*outspec) > *metadata_streams_manual = 1; > - if (type_in == 'c' || type_out == 'c') > + if (type_in == 'c' || type_out == 'c' || !*outspec) > *metadata_chapters_manual = 1; LGTM. Note: cannot reach trac at the moment. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".