From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Use all metadata selectors if none is specified.
Date: Mon, 20 Mar 2023 23:35:39 +0100
Message-ID: <20230320223539.GJ48946@mariano> (raw)
In-Reply-To: <20230315183037.74862-1-thilo.borgmann@mail.de>
On date Wednesday 2023-03-15 19:30:37 +0100, Thilo Borgmann wrote:
> Fixes regression from 3c7dd5ed37da6d2de06c4850de5a319ca9cdd47f.
> Fixes ticket #10157.
> ---
> fftools/ffmpeg_mux_init.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> index b3cc502fdd..deb09666bb 100644
> --- a/fftools/ffmpeg_mux_init.c
> +++ b/fftools/ffmpeg_mux_init.c
> @@ -1819,11 +1819,11 @@ static int copy_metadata(Muxer *mux, AVFormatContext *ic,
> parse_meta_type(mux, inspec, &type_in, &idx_in, &istream_spec);
> parse_meta_type(mux, outspec, &type_out, &idx_out, &ostream_spec);
>
> - if (type_in == 'g' || type_out == 'g')
> + if (type_in == 'g' || type_out == 'g' || !*outspec)
> *metadata_global_manual = 1;
> - if (type_in == 's' || type_out == 's')
> + if (type_in == 's' || type_out == 's' || !*outspec)
> *metadata_streams_manual = 1;
> - if (type_in == 'c' || type_out == 'c')
> + if (type_in == 'c' || type_out == 'c' || !*outspec)
> *metadata_chapters_manual = 1;
LGTM.
Note: cannot reach trac at the moment.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-20 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 18:30 Thilo Borgmann
2023-03-20 22:35 ` Stefano Sabatini [this message]
2023-03-25 19:39 ` Thilo Borgmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320223539.GJ48946@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git