Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_uspp: update to new APIs

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2210 bytes --]

On Thu, Mar 16, 2023 at 10:15:44PM +0100, Michael Niedermayer wrote:
> On Thu, Mar 16, 2023 at 01:13:54PM -0300, James Almer wrote:
> > On 3/15/2023 8:34 PM, Michael Niedermayer wrote:
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > >   configure             |  1 -
> > >   libavfilter/vf_uspp.c | 49 ++++++++++++++++++++++++++++++++++++-------
> > >   2 files changed, 41 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/configure b/configure
> > > index 03d3c429a5..0370e25577 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -7359,7 +7359,6 @@ enable frame_thread_encoder
> > >   # they are kept disabled for now, but will be removed if
> > >   # nobody updates and re-enables them
> > >   disable mcdeint_filter
> > > -disable uspp_filter
> > >   enabled asm || { arch=c; disable $ARCH_LIST $ARCH_EXT_LIST; }
> > > diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c
> > > index 051de00771..43114e1b50 100644
> > > --- a/libavfilter/vf_uspp.c
> > > +++ b/libavfilter/vf_uspp.c
> > > @@ -53,6 +53,7 @@ typedef struct USPPContext {
> > >       int outbuf_size;
> > >       uint8_t *outbuf;
> > >       AVCodecContext *avctx_enc[BLOCK*BLOCK];
> > > +    AVCodecContext *avctx_dec[BLOCK*BLOCK];
> > 
> > Wouldn't it be more efficient to try to implement recon_frame support on
> > more encoders, including snow, and limit this filter to those in patch 2/2?
> 
> recon_frame support makes sense, but i think we should have generic support
> first. Then when recon_frame is available use it.
> First make it work then make it work fast where an optimization is possible

will apply the patchset later today and then look into recon_frame in snow and uspp

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".