From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D00E545B0A for ; Thu, 16 Mar 2023 21:15:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21E9668C0DC; Thu, 16 Mar 2023 23:15:52 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A557D68C08B for ; Thu, 16 Mar 2023 23:15:46 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id A911960005 for ; Thu, 16 Mar 2023 21:15:45 +0000 (UTC) Date: Thu, 16 Mar 2023 22:15:44 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230316211544.GE375355@pb2> References: <20230315233445.5282-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_uspp: update to new APIs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4225916666115310272==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4225916666115310272== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gDGSpKKIBgtShtf+" Content-Disposition: inline --gDGSpKKIBgtShtf+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 16, 2023 at 01:13:54PM -0300, James Almer wrote: > On 3/15/2023 8:34 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > configure | 1 - > > libavfilter/vf_uspp.c | 49 ++++++++++++++++++++++++++++++++++++------- > > 2 files changed, 41 insertions(+), 9 deletions(-) > >=20 > > diff --git a/configure b/configure > > index 03d3c429a5..0370e25577 100755 > > --- a/configure > > +++ b/configure > > @@ -7359,7 +7359,6 @@ enable frame_thread_encoder > > # they are kept disabled for now, but will be removed if > > # nobody updates and re-enables them > > disable mcdeint_filter > > -disable uspp_filter > > enabled asm || { arch=3Dc; disable $ARCH_LIST $ARCH_EXT_LIST; } > > diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c > > index 051de00771..43114e1b50 100644 > > --- a/libavfilter/vf_uspp.c > > +++ b/libavfilter/vf_uspp.c > > @@ -53,6 +53,7 @@ typedef struct USPPContext { > > int outbuf_size; > > uint8_t *outbuf; > > AVCodecContext *avctx_enc[BLOCK*BLOCK]; > > + AVCodecContext *avctx_dec[BLOCK*BLOCK]; >=20 > Wouldn't it be more efficient to try to implement recon_frame support on > more encoders, including snow, and limit this filter to those in patch 2/= 2? recon_frame support makes sense, but i think we should have generic support first. Then when recon_frame is available use it. First make it work then make it work fast where an optimization is possible > I suggest this mainly seeing how you're creating 256 encoders and now also > 256 decoders, all of which might be threaded since you're not forcing them > to use a single thread, and in patch 3 you'll add slice threading on top = of > that. ill add a thread_count =3D 1 so we dont multiply the threading. if another variant is faster, of course that should be preferred [...] thx --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin --gDGSpKKIBgtShtf+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZBOG+wAKCRBhHseHBAsP q8g2AJ9POzeSVBXiQrlG51qkgSZpMtCI2wCfdWTW/fAegpTe22IC0UqiUmOqVKA= =+RAy -----END PGP SIGNATURE----- --gDGSpKKIBgtShtf+-- --===============4225916666115310272== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4225916666115310272==--