[FFmpeg-devel] [PATCH 1/2] avfilter/vf_untile: swap the chroma shift values used for plane offsets

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_untile: swap the chroma shift values used for plane offsets

[James Almer]

Fixes ticket #10265

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavfilter/vf_untile.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/vf_untile.c b/libavfilter/vf_untile.c
index 5d7709d68c..c8dafd1e60 100644
--- a/libavfilter/vf_untile.c
+++ b/libavfilter/vf_untile.c
@@ -134,8 +134,8 @@ static int activate(AVFilterContext *ctx)
         if (!(s->desc->flags & AV_PIX_FMT_FLAG_PAL)) {
             for (i = 1; i < 3; i ++) {
                 if (out->data[i]) {
-                    out->data[i] += (y >> s->desc->log2_chroma_w) * out->linesize[i];
-                    out->data[i] += (x >> s->desc->log2_chroma_h) * s->max_step[i];
+                    out->data[i] += (y >> s->desc->log2_chroma_h) * out->linesize[i];
+                    out->data[i] += (x >> s->desc->log2_chroma_w) * s->max_step[i];
                 }
             }
         }
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] fate: add a yuv422p test for the untile filter

[James Almer]

Signed-off-by: James Almer <jamrial@gmail.com>
---
 tests/fate/filter-video.mak          |  3 +++
 tests/ref/fate/filter-untile-yuv422p | 13 +++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 tests/ref/fate/filter-untile-yuv422p

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 704087b835..444adc6be6 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -314,6 +314,9 @@ FATE_FILTER_VSYNTH-$(call FILTERDEMDEC, TRIM, IMAGE2, PGM) += $(FATE_TRIM)
 FATE_FILTER-$(call FILTERFRAMECRC, TESTSRC2 UNTILE) += fate-filter-untile
 fate-filter-untile: CMD = framecrc -lavfi testsrc2=d=1:r=2,untile=2x2
 
+FATE_FILTER-$(call FILTERFRAMECRC, TESTSRC2 UNTILE) += fate-filter-untile-yuv422p
+fate-filter-untile-yuv422p: CMD = framecrc -lavfi testsrc2=d=1:r=2,format=yuv422p,untile=2x2
+
 FATE_FILTER_VSYNTH_PGMYUV-$(CONFIG_UNSHARP_FILTER) += fate-filter-unsharp
 fate-filter-unsharp: CMD = framecrc -c:v pgmyuv -i $(SRC) -vf unsharp=11:11:-1.5:11:11:-1.5
 
diff --git a/tests/ref/fate/filter-untile-yuv422p b/tests/ref/fate/filter-untile-yuv422p
new file mode 100644
index 0000000000..b212ccd8ca
--- /dev/null
+++ b/tests/ref/fate/filter-untile-yuv422p
@@ -0,0 +1,13 @@
+#tb 0: 1/8
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 160x120
+#sar 0: 1/1
+0,          0,          0,        1,    38400, 0xaadbf3e0
+0,          1,          1,        1,    38400, 0x02c882d1
+0,          2,          2,        1,    38400, 0xc246dcaa
+0,          3,          3,        1,    38400, 0x4503b0df
+0,          4,          4,        1,    38400, 0x3ed4a056
+0,          5,          5,        1,    38400, 0x374a85a6
+0,          6,          6,        1,    38400, 0xb03343d6
+0,          7,          7,        1,    38400, 0x188e8b4b
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_untile: swap the chroma shift values used for plane offsets

[Nicolas George]

[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]

James Almer (12023-03-16):
> Fixes ticket #10265
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavfilter/vf_untile.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM, thanks.

The other patch seems fine, but, I have not examined the validity of the
output visually.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".