From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5BAA245A9A for ; Tue, 14 Mar 2023 23:00:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F420E68BD6B; Wed, 15 Mar 2023 01:00:15 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A53868B115 for ; Wed, 15 Mar 2023 01:00:09 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 31AFC40003 for ; Tue, 14 Mar 2023 23:00:07 +0000 (UTC) Date: Wed, 15 Mar 2023 00:00:06 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230314230006.GC375355@pb2> References: <38e8f429-9da3-fe23-7514-e9d6aa7f32bf@gmail.com> <20230311105452.12933-1-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230311105452.12933-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v2 6/6] lavu/frame: deprecate AVFrame.pkt_{pos, size} X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7025124292345334056==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7025124292345334056== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S1BNGpv0yoYahz37" Content-Disposition: inline --S1BNGpv0yoYahz37 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 11, 2023 at 11:54:52AM +0100, Anton Khirnov wrote: > These fields are supposed to store information about the packet the > frame was decoded from, specifically the byte offset it was stored at > and its size. >=20 > However, > - the fields are highly ad-hoc - there is no strong reason why > specifically those (and not any other) packet properties should have a > dedicated field in AVFrame; unlike e.g. the timestamps, there is no > fundamental link between coded packet offset/size and decoded frames > - they only make sense for frames produced by decoding demuxed packets, > and even then it is not always the case that the encoded data was > stored in the file as a contiguous sequence of bytes (in order for pos > to be well-defined) > - pkt_pos was added without much explanation, apparently to allow > passthrough of this information through lavfi in order to handle byte > seeking in ffplay. That is now implemented using arbitrary user data > passthrough in AVFrame.opaque_ref. One intended use i remember was that errors are detected after decoding, be that bitstream, metadata, aspect ratio, yuv type, ... while the location of the error is in the source file around the packets position. pkt_pos allows one to patch errors in the source file without remuxing thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --S1BNGpv0yoYahz37 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZBD8cQAKCRBhHseHBAsP qxw1AJkBUuUJrYoaP4Qp1XbcpVYtfaY0RgCeMb1gsqftLmX7uYCZ5dk69G2JMs4= =Madp -----END PGP SIGNATURE----- --S1BNGpv0yoYahz37-- --===============7025124292345334056== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7025124292345334056==--