Re: [FFmpeg-devel] [PATCH 2/6] fftools/ffprobe: stop using AVFrame.pkt_{pos, size}

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/6] fftools/ffprobe: stop using AVFrame.pkt_{pos, size}
Date: Sun, 12 Mar 2023 16:04:14 +0100
Message-ID: <20230312150414.GB48946@mariano> (raw)
In-Reply-To: <20230310115635.13639-2-anton@khirnov.net>

On date Friday 2023-03-10 12:56:31 +0100, Anton Khirnov wrote:
> These fields are ad-hoc and will be deprecated. Use the recently-added
> AV_CODEC_FLAG_COPY_OPAQUE to pass arbitrary user data from packets to
> frames.
> 
> Changes the result of the flcl1905 test, which uses ffprobe to decode
> wmav2 with multiple frames per packet. Such packets are handled
> internally by calling the decoder's decode callback multiple times,
> offsetting the internal packet's data pointer and decreasing its size
> after each call. The output pkt_size value before this commit is then
> the remaining internal packet size at the time of each internal decode
> call.
> 
> After this commit, output pkt_size is simply the size of the full packet
> submitted by the caller to the decoder. This is more correct, since
> internal packets are never seen by the caller and should have no
> observable outside effects.
> ---
>  fftools/ffprobe.c       |  26 +++-
>  tests/ref/fate/flcl1905 | 318 ++++++++++++++++++++--------------------
>  2 files changed, 181 insertions(+), 163 deletions(-)

LGTM, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".