From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CC57B4385C for ; Sun, 5 Mar 2023 19:32:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EC84D68B6D3; Sun, 5 Mar 2023 21:32:28 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E513680547 for ; Sun, 5 Mar 2023 21:32:22 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 8720620003 for ; Sun, 5 Mar 2023 19:32:21 +0000 (UTC) Date: Sun, 5 Mar 2023 20:32:15 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230305193215.GD1928637@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v4] avformat: Add support for embedding cover art in Ogg files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1989490819763689369==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1989490819763689369== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DiL7RhKs8rK9YGuF" Content-Disposition: inline --DiL7RhKs8rK9YGuF Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 05, 2023 at 03:59:41PM +0000, Zsolt Vad=E1sz wrote: > This version can actually be applied to master. Also added checks to > ensure there won't be an OGGStreamContext for the cover art to suppress > warnings in mpv. >=20 > Signed-off-by: Zsolt Vadasz > --- > libavformat/flac_picture.c | 132 ++++++++++++++++++++++ > libavformat/flac_picture.h | 5 + > libavformat/flacenc.c | 90 +-------------- > libavformat/oggenc.c | 217 ++++++++++++++++++++++++++++++------- > 4 files changed, 319 insertions(+), 125 deletions(-) breaks fate --- ./tests/ref/lavf-fate/vp8.ogg 2023-02-25 23:39:59.312106371 +0100 +++ tests/data/fate/lavf-fate-vp8.ogg 2023-03-05 20:25:46.872310586 +0100 @@ -1,3 +1,3 @@ -20f1e9b1714513a0ba85ca636e818784 *tests/data/lavf-fate/lavf.vp8.ogg -95009 tests/data/lavf-fate/lavf.vp8.ogg -tests/data/lavf-fate/lavf.vp8.ogg CRC=3D0xa5857a66 +b6755b4eb67bac91a775e0fcc8323e49 *tests/data/lavf-fate/lavf.vp8.ogg +76738 tests/data/lavf-fate/lavf.vp8.ogg +tests/data/lavf-fate/lavf.vp8.ogg CRC=3D0xe090528e TEST checkasm-fmtconvert Test lavf-fate-vp8.ogg failed. Look at tests/data/fate/lavf-fate-vp8.ogg.er= r for details. tests/Makefile:306: recipe for target 'fate-lavf-fate-vp8.ogg' failed make: *** [fate-lavf-fate-vp8.ogg] Error 1 make: *** Waiting for unfinished jobs.... [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire --DiL7RhKs8rK9YGuF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZATuOgAKCRBhHseHBAsP q3y1AJ94I/l4k0iQeFzI2aAJ0sBeA+w+nACfQir5V2R/LQS4Od3bM1vK2cutfJM= =5HQk -----END PGP SIGNATURE----- --DiL7RhKs8rK9YGuF-- --===============1989490819763689369== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1989490819763689369==--