From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4] avformat: Add support for embedding cover art in Ogg files
Date: Sun, 5 Mar 2023 20:32:15 +0100
Message-ID: <20230305193215.GD1928637@pb2> (raw)
In-Reply-To: <ZCWGwbXJiBGav_crUhFox3--wHDSXAQ8jiXvjRMEAhf87bqJQfgcjXzxoW6g9NK4Rvh-DoxisUsqbwJSlZxgGmvlqSCu8VVdysm7Wm6y0tA=@protonmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1527 bytes --]
On Sun, Mar 05, 2023 at 03:59:41PM +0000, Zsolt Vadász wrote:
> This version can actually be applied to master. Also added checks to
> ensure there won't be an OGGStreamContext for the cover art to suppress
> warnings in mpv.
>
> Signed-off-by: Zsolt Vadasz <zsolt_vadasz@protonmail.com>
> ---
> libavformat/flac_picture.c | 132 ++++++++++++++++++++++
> libavformat/flac_picture.h | 5 +
> libavformat/flacenc.c | 90 +--------------
> libavformat/oggenc.c | 217 ++++++++++++++++++++++++++++++-------
> 4 files changed, 319 insertions(+), 125 deletions(-)
breaks fate
--- ./tests/ref/lavf-fate/vp8.ogg 2023-02-25 23:39:59.312106371 +0100
+++ tests/data/fate/lavf-fate-vp8.ogg 2023-03-05 20:25:46.872310586 +0100
@@ -1,3 +1,3 @@
-20f1e9b1714513a0ba85ca636e818784 *tests/data/lavf-fate/lavf.vp8.ogg
-95009 tests/data/lavf-fate/lavf.vp8.ogg
-tests/data/lavf-fate/lavf.vp8.ogg CRC=0xa5857a66
+b6755b4eb67bac91a775e0fcc8323e49 *tests/data/lavf-fate/lavf.vp8.ogg
+76738 tests/data/lavf-fate/lavf.vp8.ogg
+tests/data/lavf-fate/lavf.vp8.ogg CRC=0xe090528e
TEST checkasm-fmtconvert
Test lavf-fate-vp8.ogg failed. Look at tests/data/fate/lavf-fate-vp8.ogg.err for details.
tests/Makefile:306: recipe for target 'fate-lavf-fate-vp8.ogg' failed
make: *** [fate-lavf-fate-vp8.ogg] Error 1
make: *** Waiting for unfinished jobs....
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No snowflake in an avalanche ever feels responsible. -- Voltaire
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-03-05 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 15:59 Zsolt Vadász
2023-03-05 19:32 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230305193215.GD1928637@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git