From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7430540158 for ; Sun, 5 Mar 2023 11:42:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DFDFB68B1C7; Sun, 5 Mar 2023 13:42:53 +0200 (EET) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E554768ADF2 for ; Sun, 5 Mar 2023 13:42:47 +0200 (EET) Received: by mail-ed1-f52.google.com with SMTP id k10so3688840edk.13 for ; Sun, 05 Mar 2023 03:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678016566; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=jcRSlarA90XNvKMJ59S7xOOJzzf8jdoDy0QkpLsa01Q=; b=a3ph4RIOxQnIelkVnA2R9TB3tSH9sNXOaGnyCD66flIFXkDWP5TLlZgjR7tcagdI+q s0cHe1N4HvlbSQRNxnYoTLgwEpyhqoxeujSTOzET/BUVHrDI51sXBChJsKOD0w1KjkC0 Xm1KLzdwOszdmu9jkhjFwvMaAsM9L2XJxVZ/F1Kdg0NwYP9Ljz4BK9MSSBtToiwodMXm KkxV0rLOBUYb3jGXEF+QnY0UcQxVU4AQYcgwwNbPf45LM4tetlFHL5Xcj8uX++5BtGoz 4mapBEVxLO/0yvzT9l2WmACcK+Xqsz2gmMwLa3F5y4cPQa+Lop0fNclE+DGINgLzbp3v Rp7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678016566; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jcRSlarA90XNvKMJ59S7xOOJzzf8jdoDy0QkpLsa01Q=; b=ZRyEIb/QSyLN1hNets9AZQlCTEiUh5qEK2kGsS4OCj3LW2vudxmmBYo6HSHrAPOZ96 RBxsTeFjH+s78by4gY4+gWYUhXcOl5qyc9o6zznPtwqmjmc2PuLxAy0KwX9UkV3tVJoS ZCL7M2Yt44zXLe7LfN7e/dSo2uhJdb6miSypQABZNdIruFDTngUyn3nID9SUKICCDWdw gW8Wx96X5HL5uBFY0y2UBfB5HJOMOHadYfblAXfXfEiZir+/yhVzCdsSMEVYe1UJpuhM 2/BFm8AX9W/XaBLdpA/1Y+butzvfFQNOlIw6GVciXy0asCzpv2ZPTwSF8ix+qrhnCRr1 ylGQ== X-Gm-Message-State: AO0yUKXkNLeIvIj68ElVtYKRwCm2zKoBFVQuvIE+6uuA3pyUP2ZwrX4W R33QYp+MxQXzE8yhs+Vpte/vBKk+N10O/Q== X-Google-Smtp-Source: AK7set9Ykpo7tA8BascrV9ifcP2u16Uou8LsM/0U/w+5aVZbFg6PS89t0VixrLQ/NAs5y/J1ipikbw== X-Received: by 2002:a17:907:cb85:b0:8af:a53a:189d with SMTP id un5-20020a170907cb8500b008afa53a189dmr7894692ejc.44.1678016566485; Sun, 05 Mar 2023 03:42:46 -0800 (PST) Received: from mariano (dynamic-adsl-62-10-93-138.clienti.tiscali.it. [62.10.93.138]) by smtp.gmail.com with ESMTPSA id le16-20020a170907171000b008da6a37de1bsm3194831ejc.10.2023.03.05.03.42.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 03:42:45 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 7B943BFB73; Sun, 5 Mar 2023 12:42:44 +0100 (CET) Date: Sun, 5 Mar 2023 12:42:44 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230305114244.GA195575@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230301000126.49666-1-stefasab@gmail.com> <20230301000529.GE25822@mariano> <167768123137.10789.4946510304332024194@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <167768123137.10789.4946510304332024194@lain.khirnov.net> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2023-03-01 15:33:51 +0100, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-03-01 01:05:29) [...] > > BTW, I noticied this as part of debugging transcode.c (which looks > > broken at the moment), since the timebase is read as 0/1 from the > > decoder context, it would be a valid value when reading from the > > AVStream (but this information is not copied by > > avcodec_parameters_to_context). In decode_filter_video.c this is > > indeed "fixed" by copying the timebase directly from the AVStream. > > > > Is this expected? Shouldn't the timebase be copied to the decoder > > context? > > Historically, AVCodecContext.time_base for decoding was NOT (as one > might expect) the timebase of input packets, set by the user. It was > instead the inverse of the framerate stored in codec-level headers, > which was called "codec timebase" by some documents. > > Since that was massively confusing for pretty much everyone, I added > AVCodecContext.framerate for exporting the framerate from the decoder, > and deprecated the use of AVCodecContext.time_base for decoding > entirely. After the recent major bump, time_base should not be used at > all in any way when decoding. > > The timebase of input packets should instead be stored in > AVCodecContext.pkt_timebase. I suppose after some time has passed we > might want to merge its functionality into time_base. Makes sense, for the time being I understand the correct solution is to use pkt_timebase. Thank you. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".