From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C50DF404BD for ; Mon, 20 Feb 2023 13:09:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B739868BFB8; Mon, 20 Feb 2023 15:09:01 +0200 (EET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 312FF68BFA2 for ; Mon, 20 Feb 2023 15:09:00 +0200 (EET) Received: by mail-wr1-f46.google.com with SMTP id l1so874285wry.10 for ; Mon, 20 Feb 2023 05:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VQVbMqnBdmJFKVyBq452JEphqI0gdAVq3FdVUqJzAw8=; b=Odn4kUS5b3ETjkk0EAil2ANPvHoveIi7AM7syNksZc+LLic0LOR6hKGOHDfNW820bU A6Ia9xi0CMj3TDK3kwhGQ0wBM4rybUdGTEfLa15IbvP3eWJ9BDDxMW13E+gAu3q+7kt2 qo61ysSNdocjmi2Ui/FRo6HZL4pSLt/19zg1Gkxwag4OM57EalwfOBNYjqQRWpespzYu 2UCbJ1vNehtWXYtg+g7t0cA4pi7WcGbcoCMET5YfSu/8Al8mLnSvTlganqymdIogheRM lqv5BhbB7A4dNll5Q1+ACldMo0olYc64p7RLKYKJ1QQfsnD5tZo8ZwQR4BtS1eBAtK34 RKdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VQVbMqnBdmJFKVyBq452JEphqI0gdAVq3FdVUqJzAw8=; b=mtzqITDfvc41Z8YUddD4C+FEd+2LhK+cofO4tAHo3SnZ+LqsHYfrTOwoR8MxveTN9D QWjbqnPA20xDu3ZPPlovQ7PdCZS3K12AGmR0uvO8BHLjKbinQ3agTDby2Ljkss8v07e3 sdBDKqWwOtISSIAKYy6siZMl3pTBiO77daTzH+tyTrGITHeD20Gyqt4tt+RSsi3O6y8c 4x7/MONldalx/G9saqgEfIA9jAx64fgZnP737JgZcWfqY/e/ASWDljaS4nXLTsnsrlgo +53/VpxwbJhoD7O8YbH41NY56MPIcAeULlbiGEBbmwMr7nwZTUDfK6W3onEWzHZqpOMr B2+Q== X-Gm-Message-State: AO0yUKUcTsu9T+gAT3Uyi5ChdRVWs3mVWoCi+tl29vJgS7sDqXraLgYr wJdL5tVnZpM/R0EOQLGPZPrywvw04kBAzPQFS4JEKg== X-Google-Smtp-Source: AK7set/4PzZzMaRbJFuDYH8fOe9vLidXM1LEUc8l0yD9Te50vVdP4SHgKEJFTpk7Md4hh++b6/6cGg== X-Received: by 2002:a5d:5919:0:b0:2c4:24c:7d5e with SMTP id v25-20020a5d5919000000b002c4024c7d5emr551346wrd.16.1676898540269; Mon, 20 Feb 2023 05:09:00 -0800 (PST) Received: from [192.168.5.22] (d51a44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id t18-20020adfe112000000b002c3f7dfd15csm623650wrz.32.2023.02.20.05.08.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 05:08:59 -0800 (PST) Message-ID: <2c3f5377-a27b-0b90-b4e2-c0245f46a76f@obe.tv> Date: Mon, 20 Feb 2023 14:06:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230220123949.1270678-1-jdarnley@obe.tv> From: James Darnley In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] tests: actually test yadif's 10 and 16-bit functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-ID: <20230220130649.sJhac97HqdS0etO01RJeKB2eTmfXNNiKnhTp14H3YBQ@z> Archived-At: List-Archive: List-Post: On 2/20/23 13:49, Nicolas George wrote: > James Darnley (12023-02-20): > >> -fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p10le -frames:v 30 -vf yadif=0,scale >> -fate-filter-yadif16: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p16le -frames:v 30 -vf yadif=0,scale >> +fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p10le -frames:v 30 -vf scale,format=yuv420p10le,yadif=0 >> +fate-filter-yadif16: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p16le -frames:v 30 -vf scale,format=yuv420p16le,yadif=0 > > Moving scale before yadif is right, but format= is redundant with > -pix_fmt. > > Regards, > So the patch should just be moving the scale filter first? Sure. Any other comments? I wait a short while then make that change and push. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".