Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2869 bytes --]

On Fri, Feb 17, 2023 at 04:43:50AM +0100, Lynne wrote:
> This small patchset mostly rewrites Vulkan to enable using multiplane images,
> and implements video decode support. Also, many numerous bugs and issues
> were fixed, as well as having quite a lot of performance improvements.
> 
> The patchset can be viewed here as well:
> https://github.com/cyanreg/FFmpeg/tree/vulkan_staging
> 
> Patches attached.
> 

[...]
  
>  av1dec.c  |    3 +++
>  avcodec.h |    5 +++++
>  h264dec.c |    3 +++
>  hevcdec.c |    3 +++
>  vp8.c     |    3 +++
>  vp9.c     |    3 +++
>  6 files changed, 20 insertions(+)
> 122f9df511e4680d0027afae5d4f9f2f1880874e  0065-avcodec-add-AVHWAccel.flush-callback.patch
> From 93223fa95389c60c015cfcee22784a1bf0fdb05b Mon Sep 17 00:00:00 2001
> From: Lynne <dev@lynne.ee>
> Date: Fri, 6 Jan 2023 03:32:56 +0100
> Subject: [PATCH 65/72] avcodec: add AVHWAccel.flush callback

this patch seems to break fate-vp8-size-change

==5117== Invalid read of size 8
==5117==    at 0xD50598: vp8_decode_flush_impl (vp8.c:171)
==5117==    by 0xD5ACB3: ff_vp8_decode_free (vp8.c:2869)
==5117==    by 0x84CA73: avcodec_close (avcodec.c:448)
==5117==    by 0x644BB5: avformat_find_stream_info (demux.c:2969)
==5117==    by 0x243F70: ifile_open (ffmpeg_demux.c:985)
==5117==    by 0x25F60D: open_files (ffmpeg_opt.c:1244)
==5117==    by 0x25F7C4: ffmpeg_parse_options (ffmpeg_opt.c:1283)
==5117==    by 0x278003: main (ffmpeg.c:4160)
==5117==  Address 0x70 is not stack'd, malloc'd or (recently) free'd
==5117== 
==5117== 
==5117== Process terminating with default action of signal 11 (SIGSEGV)
==5117==  Access not within mapped region at address 0x70
==5117==    at 0xD50598: vp8_decode_flush_impl (vp8.c:171)
==5117==    by 0xD5ACB3: ff_vp8_decode_free (vp8.c:2869)
==5117==    by 0x84CA73: avcodec_close (avcodec.c:448)
==5117==    by 0x644BB5: avformat_find_stream_info (demux.c:2969)
==5117==    by 0x243F70: ifile_open (ffmpeg_demux.c:985)
==5117==    by 0x25F60D: open_files (ffmpeg_opt.c:1244)
==5117==    by 0x25F7C4: ffmpeg_parse_options (ffmpeg_opt.c:1283)
==5117==    by 0x278003: main (ffmpeg.c:4160)
==5117==  If you believe this happened as a result of a stack
==5117==  overflow in your program's main thread (unlikely but
==5117==  possible), you can try to increase the size of the
==5117==  main thread stack using the --main-stacksize= flag.
==5117==  The main thread stack size used in this run was 8388608.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".