Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 00/72] Implement support for Vulkan multiplane images and video decoding
Date: Fri, 17 Feb 2023 16:45:01 +0100
Message-ID: <20230217154501.GA4538@pb2> (raw)
In-Reply-To: <NOUCxYe--3-9@lynne.ee>

[-- Attachment #1.1: Type: text/plain, Size: 1773 bytes --]

On Fri, Feb 17, 2023 at 12:52:21PM +0100, Lynne wrote:
> Feb 17, 2023, 12:05 by kierank@obe.tv:
> 
> > On Fri, 17 Feb 2023 at 09:09, Jean-Baptiste Kempf <jb@videolan.org> wrote:
> >
> >> Hello,
> >>
> >> On Fri, 17 Feb 2023, at 04:43, Lynne wrote:
> >> > This small patchset mostly rewrites Vulkan to enable using multiplane
> >> images,
> >>
> >> This is not small. We're talking about thousands of lines of code;
> >>
> >> And this changes numerous h264 and hevc headers, and adds callback to the
> >> make AVHWAccel.
> >>
> >> And that is besides the full rewrite of some Vulkan files...
> >>
> >> This will take a long time to review.
> >>
> >
> > I agree.
> >
> 
> The codec changes are simple and separate, so it's not that bad to read.
> There's no more than a 100 lines or so added to the H264 parser.
> The 72 patch figure may be scary, but that's because I didn't want to
> squash my vulkan changes behind large rewrite commits. Otherwise,
> this would be a 30-commit patchset.

some of these patches are very simple, yes. Others probably not (i only looked at
the first few)
That said i was never a friend of large last minute patch-sets before releases.
I think the real deciding factor is the communities opinion and
3 Developers already are against this going in before the branching. So
unless theres a shift in oppinion i think there are more people for applying
this after branching release/6.0 than before.

Is it an issue if its only in 6.1 in 6months ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".