From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 77CAD451BC for ; Sat, 11 Feb 2023 00:19:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9C18268BCEE; Sat, 11 Feb 2023 02:19:23 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D5EA68AC05 for ; Sat, 11 Feb 2023 02:19:17 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 6C394100003 for ; Sat, 11 Feb 2023 00:19:16 +0000 (UTC) Date: Sat, 11 Feb 2023 01:19:15 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230211001915.GZ1949656@pb2> References: <20230208231006.GT1949656@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter: use ff_inlink_make_frame_writable() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7675714062904658397==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7675714062904658397== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tve/Co+tDjFhfkaB" Content-Disposition: inline --tve/Co+tDjFhfkaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 09, 2023 at 08:14:16AM +0100, Paul B Mahol wrote: > New patch attached. > avf_abitscope.c | 11 +++++++++-- > avf_ahistogram.c | 9 +++++++-- > avf_aphasemeter.c | 9 +++++++-- > avf_avectorscope.c | 7 ++++++- > avf_showspectrum.c | 5 ++++- > avf_showvolume.c | 8 ++++++-- > f_ebur128.c | 12 +++++++++--- > f_perms.c | 4 +++- > framesync.c | 2 +- > vf_cover_rect.c | 9 +++++++-- > vf_dedot.c | 2 +- > vf_floodfill.c | 5 ++++- > vf_lensfun.c | 8 +++++++- > vf_overlay_cuda.c | 3 ++- > vf_paletteuse.c | 2 +- > vf_photosensitivity.c | 3 ++- > vf_repeatfields.c | 34 +++++++++++++++++++++++++++------- > vf_signalstats.c | 27 +++++++++++++++++++++++---- > vf_telecine.c | 13 +++++++++++-- > vf_vidstabdetect.c | 12 +++++++++--- > 20 files changed, 146 insertions(+), 39 deletions(-) > d8b08205d8901abb290c603b9ea5d71264ba1b2d 0001-avfilter-use-ff_inlink_mak= e_frame_writable.patch > From 86203516a4d38f312ea5319315aa79841a39a45b Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Mon, 6 Feb 2023 14:57:50 +0100 > Subject: [PATCH] avfilter: use ff_inlink_make_frame_writable() >=20 > Signed-off-by: Paul B Mahol new failure: -i interlaced_flag_switch.mpeg -vf repeatfields -t 2 -vcodec huffyuv -bit= exact -y /tmp/file-file-repeatfields.avi [huffyuv @ 0x386098c0] using huffyuv 2.2.0 or newer interlacing flag [huffyuv @ 0x38612800] using huffyuv 2.2.0 or newer interlacing flag [huffyuv @ 0x3a9ed9c0] using huffyuv 2.2.0 or newer interlacing flag [huffyuv @ 0x3a9f4cc0] using huffyuv 2.2.0 or newer interlacing flag [huffyuv @ 0x3a9fdc00] using huffyuv 2.2.0 or newer interlacing flag [huffyuv @ 0x3aa06b40] using huffyuv 2.2.0 or newer interlacing flag [huffyuv @ 0x3aa0fa80] using huffyuv 2.2.0 or newer interlacing flag [huffyuv @ 0x16e86bc0] using huffyuv 2.2.0 or newer interlacing flag Output #0, avi, to '/tmp/file-file-repeatfields.avi': Stream #0:0: Video: huffyuv (HFYU / 0x55594648), yuv422p(tv, progressive)= , 720x480 [SAR 8:9 DAR 4:3], q=3D2-31, 200 kb/s, 29.97 fps, 29.97 tbn Metadata: encoder : Lavc huffyuv frame=3D 0 fps=3D0.0 q=3D0.0 size=3D 0kB time=3D-577014:32:22.77 b= itrate=3D -0.0kbits/s speed=3DN/A ^M=3D=3D15866=3D=3D Invalid read of s= ize 8 =3D=3D15866=3D=3D at 0x12A48B9: av_frame_is_writable (frame.c:525) =3D=3D15866=3D=3D by 0x2C2787: ff_inlink_make_frame_writable (avfilter.c= :1402) =3D=3D15866=3D=3D by 0x441284: filter_frame (vf_repeatfields.c:134) =3D=3D15866=3D=3D by 0x2C1910: ff_filter_frame_framed (avfilter.c:948) =3D=3D15866=3D=3D by 0x2C1F99: ff_filter_frame_to_filter (avfilter.c:109= 2) =3D=3D15866=3D=3D by 0x2C21A9: ff_filter_activate_default (avfilter.c:11= 41) =3D=3D15866=3D=3D by 0x2C2309: ff_filter_activate (avfilter.c:1299) =3D=3D15866=3D=3D by 0x2C6F9B: ff_filter_graph_run_once (avfiltergraph.c= :1352) =3D=3D15866=3D=3D by 0x2C84A9: push_frame (buffersrc.c:166) =3D=3D15866=3D=3D by 0x2C8B16: av_buffersrc_add_frame_flags (buffersrc.c= :255) =3D=3D15866=3D=3D by 0x26FE7D: ifilter_send_frame (ffmpeg.c:2047) =3D=3D15866=3D=3D by 0x270222: send_frame_to_filters (ffmpeg.c:2133) =3D=3D15866=3D=3D by 0x270F1A: decode_video (ffmpeg.c:2319) =3D=3D15866=3D=3D by 0x271E54: process_input_packet (ffmpeg.c:2608) =3D=3D15866=3D=3D by 0x276C31: process_input (ffmpeg.c:3857) =3D=3D15866=3D=3D by 0x2770EC: transcode_step (ffmpeg.c:3992) =3D=3D15866=3D=3D by 0x277230: transcode (ffmpeg.c:4039) =3D=3D15866=3D=3D by 0x277766: main (ffmpeg.c:4177) =3D=3D15866=3D=3D Address 0x2eb09d60 is 224 bytes inside a block of size 4= 80 free'd =3D=3D15866=3D=3D at 0x4C32D3B: free (in /usr/lib/valgrind/vgpreload_mem= check-amd64-linux.so) =3D=3D15866=3D=3D by 0x12B310B: av_free (mem.c:241) =3D=3D15866=3D=3D by 0x12B3153: av_freep (mem.c:251) =3D=3D15866=3D=3D by 0x12A3690: av_frame_free (frame.c:105) =3D=3D15866=3D=3D by 0x2C2885: ff_inlink_make_frame_writable (avfilter.c= :1431) =3D=3D15866=3D=3D by 0x44117F: filter_frame (vf_repeatfields.c:119) =3D=3D15866=3D=3D by 0x2C1910: ff_filter_frame_framed (avfilter.c:948) =3D=3D15866=3D=3D by 0x2C1F99: ff_filter_frame_to_filter (avfilter.c:109= 2) =3D=3D15866=3D=3D by 0x2C21A9: ff_filter_activate_default (avfilter.c:11= 41) =3D=3D15866=3D=3D by 0x2C2309: ff_filter_activate (avfilter.c:1299) =3D=3D15866=3D=3D by 0x2C6F9B: ff_filter_graph_run_once (avfiltergraph.c= :1352) =3D=3D15866=3D=3D by 0x2C84A9: push_frame (buffersrc.c:166) =3D=3D15866=3D=3D by 0x2C8B16: av_buffersrc_add_frame_flags (buffersrc.c= :255) =3D=3D15866=3D=3D by 0x26FE7D: ifilter_send_frame (ffmpeg.c:2047) =3D=3D15866=3D=3D by 0x270222: send_frame_to_filters (ffmpeg.c:2133) =3D=3D15866=3D=3D by 0x270F1A: decode_video (ffmpeg.c:2319) =3D=3D15866=3D=3D by 0x271E54: process_input_packet (ffmpeg.c:2608) =3D=3D15866=3D=3D by 0x276C31: process_input (ffmpeg.c:3857) =3D=3D15866=3D=3D by 0x2770EC: transcode_step (ffmpeg.c:3992) =3D=3D15866=3D=3D by 0x277230: transcode (ffmpeg.c:4039) =3D=3D15866=3D=3D Block was alloc'd at =3D=3D15866=3D=3D at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D15866=3D=3D by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgp= reload_memcheck-amd64-linux.so) =3D=3D15866=3D=3D by 0x12B2D92: av_malloc (mem.c:105) =3D=3D15866=3D=3D by 0x12A3632: av_frame_alloc (frame.c:89) =3D=3D15866=3D=3D by 0x12A46C7: av_frame_clone (frame.c:463) =3D=3D15866=3D=3D by 0x441052: filter_frame (vf_repeatfields.c:89) =3D=3D15866=3D=3D by 0x2C1910: ff_filter_frame_framed (avfilter.c:948) =3D=3D15866=3D=3D by 0x2C1F99: ff_filter_frame_to_filter (avfilter.c:109= 2) =3D=3D15866=3D=3D by 0x2C21A9: ff_filter_activate_default (avfilter.c:11= 41) =3D=3D15866=3D=3D by 0x2C2309: ff_filter_activate (avfilter.c:1299) =3D=3D15866=3D=3D by 0x2C6F9B: ff_filter_graph_run_once (avfiltergraph.c= :1352) =3D=3D15866=3D=3D by 0x2C84A9: push_frame (buffersrc.c:166) =3D=3D15866=3D=3D by 0x2C8B16: av_buffersrc_add_frame_flags (buffersrc.c= :255) =3D=3D15866=3D=3D by 0x26FE7D: ifilter_send_frame (ffmpeg.c:2047) =3D=3D15866=3D=3D by 0x270222: send_frame_to_filters (ffmpeg.c:2133) =3D=3D15866=3D=3D by 0x270F1A: decode_video (ffmpeg.c:2319) =3D=3D15866=3D=3D by 0x271E54: process_input_packet (ffmpeg.c:2608) =3D=3D15866=3D=3D by 0x276C31: process_input (ffmpeg.c:3857) =3D=3D15866=3D=3D by 0x2770EC: transcode_step (ffmpeg.c:3992) =3D=3D15866=3D=3D by 0x277230: transcode (ffmpeg.c:4039) [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --tve/Co+tDjFhfkaB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY+be/QAKCRBhHseHBAsP q2L6AJ4yfq4wLt3YT0vFo4qYnXyzNL+t6QCbBkMtx7TYCzkkJyHNI5ChhInocBE= =AqQH -----END PGP SIGNATURE----- --tve/Co+tDjFhfkaB-- --===============7675714062904658397== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7675714062904658397==--