From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A2619451B7 for ; Fri, 10 Feb 2023 23:59:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 930B968BCEE; Sat, 11 Feb 2023 01:59:45 +0200 (EET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D42B68BA81 for ; Sat, 11 Feb 2023 01:59:39 +0200 (EET) Received: by mail-wr1-f54.google.com with SMTP id r2so6740009wrv.7 for ; Fri, 10 Feb 2023 15:59:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=I738f9DjaeQVkct2pDf3Z+QW8ewD8cMAaDRCw1PrDK8=; b=a75KjROkDMzLQVFF2jqYKakk37H3o3sln5WFYr7LRqlejIfOk820vJHk31wNyrMl6a 60zZYJFy0WhCQeeONR+3Ivhn+rkxrgw29LPzx2+lexFeVf3J2aw3dik81ibDqVrxig7W OZOIck5DVxmsAmPp7fvzNgrqV4hyEh+lRmzihkspq3Oi6SHMspWmZQqbqpdVq8xdFOrQ DyZ+/e60xar2hVo2+uixRyHLoiNscqK1ivfQjIv6y31mpIrvjB2RzPp0Y+c2yJKzTkvu oBzbs4nAwiRdVEE7a8mIZ9wSG+Fb1wlW2TnQR/17xhxAhu0iTYHkEEGA3OQ9xZ2lrS9h BtzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=I738f9DjaeQVkct2pDf3Z+QW8ewD8cMAaDRCw1PrDK8=; b=AL2Prv5fzD3L4xD1LuHFNPaRMBLIZM644UZP7el+mgO7+Id4SUTzrufG6ELNQOWaeE bp6P1P4iHm9GogHeLg+gDmDNvBNq6toZ6oNl96V2dCd2xIXrzlD2IeYZE0b1Sk961xa6 0YixNgYu38HCHsMwp6R2HqeZjjPUE6P25AZJVl+psQhSiQq37Iub1otliNhqgDxNbv++ TU9HLBVf3LmDwTMQpKj3w2iuMJgs9Um5KGlT8aXYbYS1aKV5zf948s4YAhTVLitGFDg3 GjaXPK4tPArHuJXKUFHW8ozhsBbK9FxRhAVuv7m8noR6PrKy+8ZlB89ypkBdFV+h+Vhr G+UQ== X-Gm-Message-State: AO0yUKVqdmTglxfJbltRyAZFzTnqLlX5hm2lB52YcVAv62OL957/eR5M zTb5IoNNyKMcr01AIgv2GrBPmumDMq2jSL7i X-Google-Smtp-Source: AK7set9JbkROSmbfRmt6XXBbS55kIaSVT25ukMINYO3Aopxvo9Co9lm7TbGEFWZISa3PGzjDoHGi7Q== X-Received: by 2002:a5d:6750:0:b0:2be:64bb:1d84 with SMTP id l16-20020a5d6750000000b002be64bb1d84mr15233588wrw.24.1676073577633; Fri, 10 Feb 2023 15:59:37 -0800 (PST) Received: from mariano (94-37-133-75.adsl-ull.clienti.tiscali.it. [94.37.133.75]) by smtp.gmail.com with ESMTPSA id s12-20020adfdb0c000000b002c3ec1fbc0bsm4718289wri.94.2023.02.10.15.59.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 15:59:35 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id CDB2BBFB73; Sat, 11 Feb 2023 00:59:36 +0100 (CET) Date: Sat, 11 Feb 2023 00:59:36 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230210235936.GB338325@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230209142643.19623-1-anton@khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230209142643.19623-1-anton@khirnov.net> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: rename -enc_stats* to -stats_enc* X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Thursday 2023-02-09 15:26:43 +0100, Anton Khirnov wrote: > This is consistent with -stats_mux* > > As the options were added very recently, this should not break any > users. > --- > Changelog | 2 +- > doc/ffmpeg.texi | 20 ++++++++++---------- > fftools/ffmpeg_opt.c | 12 ++++++------ > 3 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/Changelog b/Changelog > index bd9fe9922d..11dfd7ef73 100644 > --- a/Changelog > +++ b/Changelog > @@ -32,7 +32,7 @@ version : > - WADY DPCM decoder and demuxer > - CBD2 DPCM decoder > - ssim360 video filter > -- ffmpeg CLI new options: -enc_stats_pre[_fmt], -enc_stats_post[_fmt], > +- ffmpeg CLI new options: -stats_enc_pre[_fmt], -stats_enc_post[_fmt], > -stats_mux_pre[_fmt] > - hstack_vaapi, vstack_vaapi and xstack_vaapi filters > - XMD ADPCM decoder and demuxer > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index 076956d128..d9d4b75567 100644 > --- a/doc/ffmpeg.texi > +++ b/doc/ffmpeg.texi > @@ -2061,30 +2061,30 @@ encoder/muxer, it does not change the stream to conform to this value. Setting > values that do not match the stream properties may result in encoding failures > or invalid output files. > > -@item -enc_stats_pre[:@var{stream_specifier}] @var{path} (@emph{output,per-stream}) > -@item -enc_stats_post[:@var{stream_specifier}] @var{path} (@emph{output,per-stream}) > +@item -stats_enc_pre[:@var{stream_specifier}] @var{path} (@emph{output,per-stream}) > +@item -stats_enc_post[:@var{stream_specifier}] @var{path} (@emph{output,per-stream}) > @item -stats_mux_pre[:@var{stream_specifier}] @var{path} (@emph{output,per-stream}) > Write per-frame encoding information about the matching streams into the file > given by @var{path}. > > -@option{-enc_stats_pre} writes information about raw video or audio frames right > -before they are sent for encoding, while @option{-enc_stats_post} writes > +@option{-stats_enc_pre} writes information about raw video or audio frames right > +before they are sent for encoding, while @option{-stats_enc_post} writes > information about encoded packets as they are received from the encoder. > @option{-stats_mux_pre} writes information about packets just as they are about to > be sent to the muxer. Every frame or packet produces one line in the specified > -file. The format of this line is controlled by @option{-enc_stats_pre_fmt} / > -@option{-enc_stats_post_fmt} / @option{-stats_mux_pre_fmt}. > +file. The format of this line is controlled by @option{-stats_enc_pre_fmt} / > +@option{-stats_enc_post_fmt} / @option{-stats_mux_pre_fmt}. > > When stats for multiple streams are written into a single file, the lines > corresponding to different streams will be interleaved. The precise order of > this interleaving is not specified and not guaranteed to remain stable between > different invocations of the program, even with the same options. > > -@item -enc_stats_pre_fmt[:@var{stream_specifier}] @var{format_spec} (@emph{output,per-stream}) > -@item -enc_stats_post_fmt[:@var{stream_specifier}] @var{format_spec} (@emph{output,per-stream}) > +@item -stats_enc_pre_fmt[:@var{stream_specifier}] @var{format_spec} (@emph{output,per-stream}) > +@item -stats_enc_post_fmt[:@var{stream_specifier}] @var{format_spec} (@emph{output,per-stream}) > @item -stats_mux_pre_fmt[:@var{stream_specifier}] @var{format_spec} (@emph{output,per-stream}) > -Specify the format for the lines written with @option{-enc_stats_pre} / > -@option{-enc_stats_post} / @option{-stats_mux_pre}. > +Specify the format for the lines written with @option{-stats_enc_pre} / > +@option{-stats_enc_post} / @option{-stats_mux_pre}. > > @var{format_spec} is a string that may contain directives of the form > @var{@{fmt@}}. @var{format_spec} is backslash-escaped --- use \@{, \@}, and \\ > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index ed7ee6ab7d..055275d813 100644 > --- a/fftools/ffmpeg_opt.c > +++ b/fftools/ffmpeg_opt.c > @@ -1544,16 +1544,16 @@ const OptionDef options[] = { > { .off = OFFSET(bits_per_raw_sample) }, > "set the number of bits per raw sample", "number" }, > > - { "enc_stats_pre", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_pre) }, > + { "stats_enc_pre", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_pre) }, > "write encoding stats before encoding" }, > - { "enc_stats_post", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_post) }, > + { "stats_enc_post", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_post) }, > "write encoding stats after encoding" }, > { "stats_mux_pre", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(mux_stats) }, > "write packets stats before muxing" }, > - { "enc_stats_pre_fmt", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_pre_fmt) }, > - "format of the stats written with -enc_stats_pre" }, > - { "enc_stats_post_fmt", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_post_fmt) }, > - "format of the stats written with -enc_stats_post" }, > + { "stats_enc_pre_fmt", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_pre_fmt) }, > + "format of the stats written with -stats_enc_pre" }, > + { "stats_enc_post_fmt", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(enc_stats_post_fmt) }, > + "format of the stats written with -stats_enc_post" }, > { "stats_mux_pre_fmt", HAS_ARG | OPT_SPEC | OPT_EXPERT | OPT_OUTPUT | OPT_STRING, { .off = OFFSET(mux_stats_fmt) }, > "format of the stats written with -stats_mux_pre" }, LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".