From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5ADBB45128 for ; Wed, 8 Feb 2023 23:41:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 71A4368BB94; Thu, 9 Feb 2023 01:41:26 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F0C868BB94 for ; Thu, 9 Feb 2023 01:41:20 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 936F720005 for ; Wed, 8 Feb 2023 23:41:19 +0000 (UTC) Date: Thu, 9 Feb 2023 00:41:18 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230208234118.GU1949656@pb2> References: <20230125010744.255455-1-stefasab@gmail.com> <29fe7152-55a9-8354-b018-60d4ac6e8681@gyani.pro> <20230206012523.GA338325@mariano> MIME-Version: 1.0 In-Reply-To: <20230206012523.GA338325@mariano> Subject: Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: extend -dts_delta_threshold option description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3249183672201626070==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3249183672201626070== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NJBzyuYYykgY2yjn" Content-Disposition: inline --NJBzyuYYykgY2yjn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 06, 2023 at 02:25:23AM +0100, Stefano Sabatini wrote: > On date Wednesday 2023-01-25 10:47:20 +0530, Gyan Doshi wrote: > >=20 > >=20 > > On 2023-01-25 06:37 am, Stefano Sabatini wrote: > > > --- > > > doc/ffmpeg.texi | 17 +++++++++++++++-- > > > 1 file changed, 15 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > > > index 67b3294256..122f7e3387 100644 > > > --- a/doc/ffmpeg.texi > > > +++ b/doc/ffmpeg.texi > > > @@ -1823,8 +1823,21 @@ results, but increase memory use and latency. > > > The default value is 10 seconds. > > > -@item -dts_delta_threshold > > > -Timestamp discontinuity delta threshold. > > > +@item -dts_delta_threshold @var{threshold} > > > +Timestamp discontinuity delta threshold, expressed as a floating poi= nt > > > +number of @var{AV_TIME_BASE} units. > > This is a CLI option and those users don't deal with AV_TIME_BASE . More > > useful to say it's in seconds. > >=20 > > > + > > > +If a timestamp discontinuity is detected whose absolute value is > > > +greater than @var{threshold} * @var{AV_TIME_BASE}, ffmpeg will remov= e the > > > +discontinuity by decreasing/increasing the current DTS and PTS by the > > > +corresponding delta value. > >=20 >=20 > > Might want to mention that this only applies to AV_FMT_DISCONT demuxers= , or > > rather give a few examples, like MPEG-TS, HLS..etc. > > For all other formats that users normally work with, clarify that only > > dts_error_threshold is relevant. >=20 >=20 > > > + > > > +Timestamp discontinuity correction can be inhibited by setting a big= value for > > > +@var{threshold}, and is automatically disabled when employing the > > > +@code{-copy_ts} option. > >=20 > > For copy_ts, it is still applied for all negative deltas except the > > smallest. >=20 > Which is a bit arbitrary. >=20 > >=20 > > Not blocking, but I'm reworking this code at present. Shouldn't really > > affect this patch. See > > https://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305539.html >=20 > Updated (had to review the code to get some clarity on the current > behavior). >=20 > Thanks. > doc/ffmpeg.texi | 36 ++++++++++++++++++---- > fftools/ffmpeg.c | 72 +++++++++++++++++++++++--------------= ------- > fftools/ffmpeg.h | 2 + > fftools/ffmpeg_demux.c | 3 + > tests/fate/filter-audio.mak | 2 - > tests/fate/mpeg4.mak | 2 - > 6 files changed, 77 insertions(+), 40 deletions(-) > 55e91624524749274a62bdc43cacdf8e47dd3598 0002-ffmpeg-review-dts_delta_th= reshold-and-dts_delta_erro.patch > From 30ac56a14d66eb25428b71c9211f401f818bd057 Mon Sep 17 00:00:00 2001 > From: Stefano Sabatini > Date: Fri, 1 Apr 2011 01:13:35 +0200 > Subject: [PATCH 2/2] ffmpeg: review -dts_delta_threshold and -dts_delta_e= rror > options >=20 > Review handling of -dts_delta_threshold and -dts_delta_error options, > specify them as floating point expressed in seconds. >=20 > Also, review and simplify logic. Adjust values for tests, since in > some cases the new values does not trigger the correction logic. >=20 > PR: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3D8252 > --- > doc/ffmpeg.texi | 36 ++++++++++++++++--- > fftools/ffmpeg.c | 72 ++++++++++++++++++++----------------- > fftools/ffmpeg.h | 2 ++ > fftools/ffmpeg_demux.c | 3 ++ > tests/fate/filter-audio.mak | 2 +- > tests/fate/mpeg4.mak | 2 +- > 6 files changed, 77 insertions(+), 40 deletions(-) This seems to break a case with concat and vsync =2E/ffmpeg -y -i 'concat:///home/michael/videos/angels.mpg|/home/michael/vi= deos/angels.mpg' -vsync 0 -an file.avi =2E.. cpb: bitrate max/min/avg: 0/0/200000 buffer size: 0 vbv_delay: N/A [mpeg4 @ 0x55e051b8d4c0] Invalid pts (0) <=3D last (11)00.00 bitrate=3DN/A = speed=3D 0x =20 [vost#0:0/mpeg4 @ 0x55e051b9d700] Error submitting video frame to the encod= er Conversion failed! Ill mail you the angels.mpg, i think its online somewhere but i cant find it thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom Scott --NJBzyuYYykgY2yjn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY+QzGAAKCRBhHseHBAsP q7gFAKCasa9MM1YkPxmQxCNAYKH4FP6+twCfWrcKw+B+mDRBLrEYtMq8R0K7tZ4= =MYLs -----END PGP SIGNATURE----- --NJBzyuYYykgY2yjn-- --===============3249183672201626070== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3249183672201626070==--