* [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy()
@ 2023-02-07 14:58 Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 2/4] avformat/hls: relay programs to child muxers Gyan Doshi
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Gyan Doshi @ 2023-02-07 14:58 UTC (permalink / raw)
To: ffmpeg-devel
Needed to transfer programs in parent muxing contexts to child muxers,
like in hls, segment, tee muxers.
---
doc/APIchanges | 3 +++
libavformat/avformat.c | 52 ++++++++++++++++++++++++++++++++++++++++++
libavformat/avformat.h | 2 ++
libavformat/version.h | 2 +-
4 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 6baf914760..4916d1abe8 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -14,6 +14,9 @@ libavutil: 2021-04-27
API changes, most recent first:
+2023-02-xx - xxxxxxxxxx - lavf 59.39.100 - avformat.h
+ Add av_program_copy()
+
2023-0x-xx - xxxxxxxxxx - lavc 59.63.100
Allow AV_CODEC_FLAG_COPY_OPAQUE to be used with decoders.
diff --git a/libavformat/avformat.c b/libavformat/avformat.c
index 19c7219471..ddea692cee 100644
--- a/libavformat/avformat.c
+++ b/libavformat/avformat.c
@@ -359,6 +359,58 @@ void av_program_add_stream_index(AVFormatContext *ac, int progid, unsigned idx)
}
}
+int av_program_copy(AVFormatContext *dst, AVFormatContext *src, int progid)
+{
+ AVProgram *src_prog = NULL;
+ AVProgram *dst_prog = NULL;
+ int i, j, ret;
+
+ for (i = 0; i < src->nb_programs; i++)
+ if (src->programs[i]->id == progid)
+ src_prog = src->programs[i];
+
+ if (!src_prog) {
+ av_log(src, AV_LOG_ERROR, "program not found: id=0x%04x\n", progid);
+ return AVERROR(EINVAL);
+ }
+
+ av_log(src, AV_LOG_TRACE, "copying program: id=0x%04x\n", progid);
+
+ dst_prog = av_mallocz(sizeof(*dst_prog));
+ if (!dst_prog)
+ return AVERROR(ENOMEM);
+ ret = av_dynarray_add_nofree(&dst->programs, &dst->nb_programs, dst_prog);
+ if (ret < 0) {
+ av_free(dst_prog);
+ return AVERROR(ENOMEM);
+ }
+
+ /* public fields */
+ dst_prog->id = src_prog->id;
+ dst_prog->flags = src_prog->flags;
+ dst_prog->discard = src_prog->discard;
+ dst_prog->program_num = src_prog->program_num;
+ dst_prog->pmt_pid = src_prog->pmt_pid;
+ dst_prog->pcr_pid = src_prog->pcr_pid;
+ dst_prog->pmt_version = src_prog->pmt_version;
+
+ for (i = 0; i < dst->nb_streams; i++) {
+ for (j = 0; j < src_prog->nb_stream_indexes; j++)
+ if (dst->streams[i]->id == src->streams[src_prog->stream_index[j]]->id)
+ av_program_add_stream_index(dst, dst_prog->id, i);
+ }
+
+ av_dict_copy(&dst_prog->metadata, src_prog->metadata, 0);
+
+ /* private fields */
+ dst_prog->start_time = src_prog->start_time;
+ dst_prog->end_time = src_prog->end_time;
+ dst_prog->pts_wrap_reference = src_prog->pts_wrap_reference;
+ dst_prog->pts_wrap_behavior = src_prog->pts_wrap_behavior;
+
+ return 0;
+}
+
AVProgram *av_find_program_from_stream(AVFormatContext *ic, AVProgram *last, int s)
{
for (unsigned i = 0; i < ic->nb_programs; i++) {
diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 1d97d56ac5..db1d8c4fba 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -1996,6 +1996,8 @@ uint8_t *av_stream_get_side_data(const AVStream *stream,
AVProgram *av_new_program(AVFormatContext *s, int id);
+int av_program_copy(AVFormatContext *dst, AVFormatContext *src, int progid);
+
/**
* @}
*/
diff --git a/libavformat/version.h b/libavformat/version.h
index 134cdb2b89..9aba356e09 100644
--- a/libavformat/version.h
+++ b/libavformat/version.h
@@ -31,7 +31,7 @@
#include "version_major.h"
-#define LIBAVFORMAT_VERSION_MINOR 38
+#define LIBAVFORMAT_VERSION_MINOR 39
#define LIBAVFORMAT_VERSION_MICRO 100
#define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, \
--
2.39.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH 2/4] avformat/hls: relay programs to child muxers
2023-02-07 14:58 [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Gyan Doshi
@ 2023-02-07 14:58 ` Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 3/4] avformat/segment: " Gyan Doshi
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Gyan Doshi @ 2023-02-07 14:58 UTC (permalink / raw)
To: ffmpeg-devel
---
libavformat/hlsenc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 39df9becc7..bfad1eef90 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -907,6 +907,12 @@ static int hls_mux_init(AVFormatContext *s, VariantStream *vs)
st->id = vs->streams[i]->id;
}
+ for (i = 0; i < s->nb_programs; i++) {
+ ret = av_program_copy(oc, s, s->programs[i]->id);
+ if (ret < 0)
+ av_log(s, AV_LOG_WARNING, "unable to transfer program %d to child muxer\n", s->programs[i]->id);
+ }
+
vs->start_pos = 0;
vs->new_start = 1;
--
2.39.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH 3/4] avformat/segment: relay programs to child muxers
2023-02-07 14:58 [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 2/4] avformat/hls: relay programs to child muxers Gyan Doshi
@ 2023-02-07 14:58 ` Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 4/4] avformat/tee: " Gyan Doshi
2023-02-08 15:17 ` [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Anton Khirnov
3 siblings, 0 replies; 6+ messages in thread
From: Gyan Doshi @ 2023-02-07 14:58 UTC (permalink / raw)
To: ffmpeg-devel
---
libavformat/segment.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libavformat/segment.c b/libavformat/segment.c
index 80e4bf851c..a5acc28dfd 100644
--- a/libavformat/segment.c
+++ b/libavformat/segment.c
@@ -182,6 +182,12 @@ static int segment_mux_init(AVFormatContext *s)
}
}
+ for (i = 0; i < s->nb_programs; i++) {
+ ret = av_program_copy(oc, s, s->programs[i]->id);
+ if (ret < 0)
+ av_log(s, AV_LOG_WARNING, "unable to transfer program %d to child muxer\n", s->programs[i]->id);
+ }
+
return 0;
}
--
2.39.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH 4/4] avformat/tee: relay programs to child muxers
2023-02-07 14:58 [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 2/4] avformat/hls: relay programs to child muxers Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 3/4] avformat/segment: " Gyan Doshi
@ 2023-02-07 14:58 ` Gyan Doshi
2023-02-08 15:17 ` [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Anton Khirnov
3 siblings, 0 replies; 6+ messages in thread
From: Gyan Doshi @ 2023-02-07 14:58 UTC (permalink / raw)
To: ffmpeg-devel
---
libavformat/tee.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libavformat/tee.c b/libavformat/tee.c
index dd408dd096..fd1b17ce7c 100644
--- a/libavformat/tee.c
+++ b/libavformat/tee.c
@@ -291,6 +291,12 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_slave)
}
}
+ for (i = 0; i < avf->nb_programs; i++) {
+ ret = av_program_copy(avf2, avf, avf->programs[i]->id);
+ if (ret < 0)
+ av_log(avf, AV_LOG_WARNING, "unable to transfer program %d to child muxer\n", avf->programs[i]->id);
+ }
+
ret = ff_format_output_open(avf2, filename, &options);
if (ret < 0) {
av_log(avf, AV_LOG_ERROR, "Slave '%s': error opening: %s\n", slave,
--
2.39.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy()
2023-02-07 14:58 [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Gyan Doshi
` (2 preceding siblings ...)
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 4/4] avformat/tee: " Gyan Doshi
@ 2023-02-08 15:17 ` Anton Khirnov
2023-02-08 16:03 ` Gyan Doshi
3 siblings, 1 reply; 6+ messages in thread
From: Anton Khirnov @ 2023-02-08 15:17 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Quoting Gyan Doshi (2023-02-07 15:58:47)
> Needed to transfer programs in parent muxing contexts to child muxers,
> like in hls, segment, tee muxers.
If it's only intended for use in muxers, why is it public?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy()
2023-02-08 15:17 ` [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Anton Khirnov
@ 2023-02-08 16:03 ` Gyan Doshi
0 siblings, 0 replies; 6+ messages in thread
From: Gyan Doshi @ 2023-02-08 16:03 UTC (permalink / raw)
To: ffmpeg-devel
On 2023-02-08 08:47 pm, Anton Khirnov wrote:
> Quoting Gyan Doshi (2023-02-07 15:58:47)
>> Needed to transfer programs in parent muxing contexts to child muxers,
>> like in hls, segment, tee muxers.
> If it's only intended for use in muxers, why is it public?
Could have worded the msg better. The intention wasn't to limit this
internally.
The fn is motivated by a CLI HLS user's troubleshhoting but it is useful
to any API user who uses
the public av_new_program and then copies the data manually.
That reminds me, I should update this to check for existing programs.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-08 16:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 14:58 [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 2/4] avformat/hls: relay programs to child muxers Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 3/4] avformat/segment: " Gyan Doshi
2023-02-07 14:58 ` [FFmpeg-devel] [PATCH 4/4] avformat/tee: " Gyan Doshi
2023-02-08 15:17 ` [FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy() Anton Khirnov
2023-02-08 16:03 ` Gyan Doshi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git