Re: [FFmpeg-devel] [PATCH v2 10/33] avcodec: remove FF_API_THREAD_SAFE_CALLBACKS

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 10/33] avcodec: remove FF_API_THREAD_SAFE_CALLBACKS
Date: Sun, 5 Feb 2023 22:04:39 +0100
Message-ID: <20230205210439.GP1949656@pb2> (raw)
In-Reply-To: <20230204104204.20721-11-anton@khirnov.net>

[-- Attachment #1.1: Type: text/plain, Size: 1646 bytes --]

On Sat, Feb 04, 2023 at 11:41:41AM +0100, Anton Khirnov wrote:
> From: James Almer <jamrial@gmail.com>
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  fftools/ffmpeg.c                  |   5 -
>  libavcodec/avcodec.h              |  21 ---
>  libavcodec/decode.c               |  13 --
>  libavcodec/encode.c               |   7 +-
>  libavcodec/frame_thread_encoder.c |  20 ---
>  libavcodec/pthread_frame.c        | 237 +-----------------------------
>  libavcodec/thread.h               |  12 --
>  libavcodec/version_major.h        |   1 -
>  8 files changed, 6 insertions(+), 310 deletions(-)

This seems to break build without pthreads

libavcodec/libavcodec.a(utils.o): In function `ff_get_format':
libavcodec/utils.c:917: multiple definition of `ff_get_format'
libavcodec/libavcodec.a(decode.o):libavcodec/decode.c:1147: first defined here
collect2: error: ld returned 1 exit status
Makefile:131: recipe for target 'ffplay_g' failed
make: *** [ffplay_g] Error 1
make: *** Waiting for unfinished jobs....
libavcodec/libavcodec.a(utils.o): In function `ff_get_format':
libavcodec/utils.c:917: multiple definition of `ff_get_format'
libavcodec/libavcodec.a(decode.o):libavcodec/decode.c:1147: first defined here
collect2: error: ld returned 1 exit status
Makefile:131: recipe for target 'ffprobe_g' failed
make: *** [ffprobe_g] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".