Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: fix af_pan regression
Date: Sun, 5 Feb 2023 20:58:14 +0100
Message-ID: <20230205195814.GO1949656@pb2> (raw)
In-Reply-To: <CAPYw7P6bbLiSj_bUGiv_GWk9sZbJkBo1yGKFAhdHDKaUWuRg3g@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 3709 bytes --]

On Sat, Feb 04, 2023 at 09:48:38PM +0100, Paul B Mahol wrote:
> Patch attached.

>  af_pan.c |    3 +++
>  1 file changed, 3 insertions(+)
> bf878b3bd193e6462d1babf5e6e45a056a3a0f65  0001-avfilter-af_pan-fix-regression-introduced-with-switc.patch
> From b53fa290876af0f540a99f733193f270103bf8ad Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Sat, 4 Feb 2023 21:46:15 +0100
> Subject: [PATCH] avfilter/af_pan: fix regression introduced with switch to new
>  channel layout API
> 
> Fixes #10168
> 
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavfilter/af_pan.c | 3 +++
>  1 file changed, 3 insertions(+)

This seems to change fate output

@@ -3,23 +3,23 @@
 #codec_id 0: pcm_s16le
 #sample_rate 0: 44100
 #channel_layout_name 0: mono
-0,          0,          0,     1024,     2048, 0x750f0a66
-0,       1024,       1024,     1024,     2048, 0x155cf063
-0,       2048,       2048,     1024,     2048, 0x1e43fc32
-0,       3072,       3072,     1024,     2048, 0x282ffc28
-0,       4096,       4096,     1024,     2048, 0x6d7bf000
-0,       5120,       5120,     1024,     2048, 0xc0b2f411
-0,       6144,       6144,     1024,     2048, 0xd711fb03
-0,       7168,       7168,     1024,     2048, 0x3164189c
-0,       8192,       8192,     1024,     2048, 0x8c69e827
-0,       9216,       9216,     1024,     2048, 0x562d0518
-0,      10240,      10240,     1024,     2048, 0x380aee27
-0,      11264,      11264,     1024,     2048, 0x990a03e4
-0,      12288,      12288,     1024,     2048, 0x68d7ef60
-0,      13312,      13312,     1024,     2048, 0xd13fef9e
-0,      14336,      14336,     1024,     2048, 0x009306e4
-0,      15360,      15360,     1024,     2048, 0x51850390
-0,      16384,      16384,     1024,     2048, 0xcd3ceeae
-0,      17408,      17408,     1024,     2048, 0x189ff277
-0,      18432,      18432,     1024,     2048, 0x4b98f68c
-0,      19456,      19456,     1024,     2048, 0x34eaf544
+0,          0,          0,     1024,     2048, 0xd883fc1d
+0,       1024,       1024,     1024,     2048, 0xbfd0f2a0
+0,       2048,       2048,     1024,     2048, 0x88b90294
+0,       3072,       3072,     1024,     2048, 0x60dcf6f4
+0,       4096,       4096,     1024,     2048, 0x2cde0191
+0,       5120,       5120,     1024,     2048, 0x4543e9ea
+0,       6144,       6144,     1024,     2048, 0x4f73f86b
+0,       7168,       7168,     1024,     2048, 0x1a600893
+0,       8192,       8192,     1024,     2048, 0x02f3fe62
+0,       9216,       9216,     1024,     2048, 0xdbf200ac
+0,      10240,      10240,     1024,     2048, 0xd806ebf7
+0,      11264,      11264,     1024,     2048, 0xb2d9f805
+0,      12288,      12288,     1024,     2048, 0x47bb087b
+0,      13312,      13312,     1024,     2048, 0x96520fb5
+0,      14336,      14336,     1024,     2048, 0xfb8efbd5
+0,      15360,      15360,     1024,     2048, 0xbf2f03ed
+0,      16384,      16384,     1024,     2048, 0xde80fd74
+0,      17408,      17408,     1024,     2048, 0xf204e97d
+0,      18432,      18432,     1024,     2048, 0x260cf5d2
+0,      19456,      19456,     1024,     2048, 0x0d02ff6c
Test filter-pan-mono1 failed. Look at tests/data/fate/filter-pan-mono1.err for details.
tests/Makefile:306: recipe for target 'fate-filter-pan-mono1' failed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-02-05 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-04 20:48 Paul B Mahol
2023-02-05 19:58 ` Michael Niedermayer [this message]
2023-02-05 20:37   ` Paul B Mahol
2023-02-07 17:04     ` Paul B Mahol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230205195814.GO1949656@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git