From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1B81444208 for ; Thu, 2 Feb 2023 15:09:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F3D4E68B4A7; Thu, 2 Feb 2023 17:09:48 +0200 (EET) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1B6868B4A7 for ; Thu, 2 Feb 2023 17:09:42 +0200 (EET) Received: by mail-il1-f180.google.com with SMTP id z2so864434ilq.2 for ; Thu, 02 Feb 2023 07:09:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MW8C1rD0ALJ2gv4Q6L3ZYQRSOsPXH/faQJgCWB5Y4bg=; b=IB2p4JF7zO2tT9Qfqy6O689OIH+WxK4BlDBw5Cb7zGn3cfZUkq8v98nrS3v4ncONnQ x/6CzC8O+AD1FjyPqZndEgRu60qkFqs5M+MZn1biySmAW1dL2jAHdcFeuOFBrVpbhw9h Vr3VffABBlp9mKaFIOmtYSg4Gz0pG98vy9NBE+wR24Y8pgwaeG/m7LTpXv0OInLdmIyy TUJQJB8/Pt31g2zqlz7L1ZNfp77+ic22s/cuz8et3ZPQqpEayrEiLdtRQ4hfclzBkX/+ uXdefJYd1Na55csG/TqsbDLkPJtHm+EafqosYoCP3DxGGwphZfhwy6IyCfoEbq/KInJ4 8DEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MW8C1rD0ALJ2gv4Q6L3ZYQRSOsPXH/faQJgCWB5Y4bg=; b=IInljC3pS6hvL1vAONNTO099lKAeqjU7cD0stWzyK+GXUQtM+A2aDOyKYoLbGDDqnf PfkrcaehPeYZBEH4oFrJTnAlbxr+TYMm5qoJxlBSV2RgcM7YcVYAwKtg2FAXcSP+/rWQ V+w3KsOK74GTBHXikhIz51+L/PDW6g0H6tlVdlKxahWq32xVkua+dCh/cFUxqmqqZ485 x0CRL34zcQZVAnsshzVNaxzscx42/c9A3sXFEphaoQ+Fr+TNvj9TCnCXa7E7/7IRhv16 MUWr5ARqCysI9M724pBQ3Oj7uo5QvgSj+zIGS7FK+LJoN6sZJ2fHpoDQawYTa9cNwRUT D3iw== X-Gm-Message-State: AO0yUKVzXaAi/fadxJmV1YdSYSElKhYZVGsi1M/pZs/hRSyXJH6fQstE Aw1QG7VtqUmTxWZVVYWELl7sU3aN0EGadQ== X-Google-Smtp-Source: AK7set8f/njs9Dvx2tZdNtTcbu0fMKN/Klp6h67PXnsZWiQsrUC4XAMSuzZFGhN4DYH0pg4XJ1R62Q== X-Received: by 2002:a05:6e02:152:b0:310:cc70:a152 with SMTP id j18-20020a056e02015200b00310cc70a152mr4355280ilr.2.1675350580964; Thu, 02 Feb 2023 07:09:40 -0800 (PST) Received: from gauss.local (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id r7-20020a92d987000000b0030f43cefc4bsm6570122iln.53.2023.02.02.07.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 07:09:40 -0800 (PST) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Thu, 2 Feb 2023 10:09:35 -0500 Message-Id: <20230202150938.22297-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 0/3] PNG color tagging improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The first patch fixes a FATE issue with cICP and iCCP. The second patch was discussed on IRC. I got a LGTM from Kasper, but sending to ML here and applying in a few days if there's no objections. A few things discussed: 1) There's no need to expose the gamma table as another function as it's only used here. 2) This patch includes the patch on the ML sent as "avcodec/pngdec: warn when reading tv-range cICP chunks" which got a LGTM from Lynne on IRC. If this is applied that one has no need to be applied. Changes from v2: - Split off the gAMA chunk handling into a second patch at Andreas' suggestion. Changes from v1: - The second patch broke FATE because I didn't change the fate ref to accommodate the new metadata. I've since updated the fate reference. Leo Izen (3): avcodec/pngenc: avoid writing cICP when inappropriate avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL avcodec/pngdec: populate enum transfer values from gAMA chunk libavcodec/pngdec.c | 128 +++++++++++++++++++++-------------- libavcodec/pngenc.c | 21 ++++-- tests/ref/fate/png-icc | 8 +-- tests/ref/fate/png-side-data | 2 +- 4 files changed, 96 insertions(+), 63 deletions(-) -- 2.39.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".