From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 622194010F for ; Wed, 1 Feb 2023 17:44:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9D1C468BE8C; Wed, 1 Feb 2023 19:44:22 +0200 (EET) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B01D68BD85 for ; Wed, 1 Feb 2023 19:44:16 +0200 (EET) Received: by mail-io1-f47.google.com with SMTP id 65so4413294iou.3 for ; Wed, 01 Feb 2023 09:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qEGeRMfhVc2fT91Aw/BdRb72ogsoLfh3vIHFMjwdSn8=; b=lJjqsGtZ8ijZbHiI7rvk6KE4B5lbOlvjlYrLo1/vZLDQbWhtSMiiqymJoDUArM4Hrh I3FbaswtalDWDsZGfQUy1i4IC5zf68KAkdoXEodS6IUXXweTwcr1+7Bxj5XaPBo0gHpk SjKXwSrVFpUMv13zmXpET/HWBUP8ifKw4UVeASQKRJ0nMak30/HgY5+nvniml2HZSt2K cJ6taARoi6Q1MwbnTgul98UvnbafUrAQQkRAGc2BQ0ssyAUkvbjP5TzJ52NmG1jrDmNT 6+Qn4nYP2iFqh9Dqs1BdJsbl7+xPoLejb9hfkSz3e7sj0lUYb0vGD6x7QiVy5WqF+qG+ mNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qEGeRMfhVc2fT91Aw/BdRb72ogsoLfh3vIHFMjwdSn8=; b=cm56chonak3Qq+ziP4NeqFeMJmClszWicM7k4msGiTAmr8lbW6WWKcw+GrDZjD0Cex mVUmESKpLBWevJT8JkxcA+Dcz08JOM0p1axPFaTuQ0tJ6nZVk62jkzScayVck4cqjbS0 EgbmwgPGpCY1cplCQ3NrT03x7pjrrsowd57z0chQlEoRchK6Zcj4WNAEgIi7+w4uPV09 EBvAwQ/GnSViXQMpemfEMYHoKGdJo0OL9VBHwhYOJubXnAOB6Yha6kmQAxz0ljbD5yxo dCSMiAY1Nx5AqiB7u4Bh6JSLYgW+ZxYEy/G7NQciwGCRNFspgUOpynmjSTuPiJTfam/R T6Gw== X-Gm-Message-State: AO0yUKVkIyvBp49gbYKdjdEOcybYDApBfmyxVSzdZ0mw8/FFLvJRNpNW pywCxHp6Z5U7Nqk4+a5huDuoJ7dvq2lnVg== X-Google-Smtp-Source: AK7set9DyFwPVxONaasaaCa2Vl0oumTvhvfuGaMptavqz876oWvFSpgqomG/FbaJNbOoBi5haBXdFQ== X-Received: by 2002:a5d:954b:0:b0:70a:9fce:853c with SMTP id a11-20020a5d954b000000b0070a9fce853cmr1789007ios.2.1675273455054; Wed, 01 Feb 2023 09:44:15 -0800 (PST) Received: from gauss.local (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id c13-20020a6b4e0d000000b00704a77b7b28sm5925685iob.54.2023.02.01.09.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 09:44:14 -0800 (PST) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Feb 2023 12:44:10 -0500 Message-Id: <20230201174412.78042-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 0/2] PNG cICP improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The first patch fixes a FATE issue with cICP and iCCP. The second patch was discussed on IRC. I got a LGTM from Kasper, but sending to ML here and applying in a few days if there's no objections. A few things discussed: 1) There's no need to expose the gamma table as another function as it's only used here. 2) This patch includes the patch on the ML sent as "avcodec/pngdec: warn when reading tv-range cICP chunks" which got a LGTM from Lynne on IRC. If this is applied that one has no need to be applied. Changes from v1: - The second patch broke FATE because I didn't change the fate ref to accommodate the new metadata. I've since updated the fate reference. Leo Izen (2): avcodec/pngenc.c: avoid writing cICP when inappropriate avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL libavcodec/pngdec.c | 126 +++++++++++++++++++++-------------- libavcodec/pngenc.c | 21 ++++-- tests/ref/fate/png-icc | 8 +-- tests/ref/fate/png-side-data | 2 +- 4 files changed, 94 insertions(+), 63 deletions(-) -- 2.39.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".