Re: [FFmpeg-devel] [PATCH 3/3] libavformat/lafdec: free data

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1657 bytes --]

On Tue, Jan 31, 2023 at 12:25:25PM +0100, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Fixes: memleak
> > 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavformat/lafdec.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/libavformat/lafdec.c b/libavformat/lafdec.c
> > index b78ec3649c..f6d2d5f235 100644
> > --- a/libavformat/lafdec.c
> > +++ b/libavformat/lafdec.c
> > @@ -253,6 +253,15 @@ again:
> >      return 0;
> >  }
> >  
> > +static int laf_read_close(AVFormatContext *ctx)
> > +{
> > +    LAFContext *s = ctx->priv_data;
> > +
> > +    av_freep(&s->data);
> > +
> > +    return 0;
> > +}
> > +
> >  static int laf_read_seek(AVFormatContext *ctx, int stream_index,
> >                           int64_t timestamp, int flags)
> >  {
> > @@ -270,6 +279,7 @@ const AVInputFormat ff_laf_demuxer = {
> >      .read_probe     = laf_probe,
> >      .read_header    = laf_read_header,
> >      .read_packet    = laf_read_packet,
> > +    .read_close     = laf_read_close,
> >      .read_seek      = laf_read_seek,
> >      .extensions     = "laf",
> >      .flags          = AVFMT_GENERIC_INDEX,
> 
> Needs the FF_FMT_INIT_CLEANUP flag, too (otherwise it will leak in case
> of avformat_new_stream() failure).

ok, will apply with this

thx

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".