From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C5FF44544B for ; Mon, 30 Jan 2023 05:23:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E66AD68BDA0; Mon, 30 Jan 2023 07:23:55 +0200 (EET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 19A0668BD90 for ; Mon, 30 Jan 2023 07:23:48 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675056234; x=1706592234; h=from:to:cc:subject:date:message-id; bh=2/PXaD5Ejr0ApHCDlA1cLyqBuaL+vjQ5dkKOT/d8Sqo=; b=i9ShvnrOyz7+ixOjusjYGeIsoVEC7kIvWEtHNSHV6z8wMn7r4Of7Lm7U UREfnT6cAoeAMPVrTe7WYIjBzc6FrvBzIqVECEj/VjjJMDWwsZ80T6xkx lxR6ModuhswBejwpogGCdrNc+3c+yhbCWpI2NRCy7Lx5lNuycKUbCPiCm dvOE3RKQeLo9Z8VngvCMSDz+CSOlgOJU6BD6kfEH6/xgVLnItlLg0mN/L Hyr5d332X87RpeWhGbc/deUSJJHmRHyg1L6pxNwlz86T8M+/LR5ewXYfi OOSEDE2uR3xVm0teOHRiURhP6nJe8KW1+gy27Xz+pIMII45sRWsRgcdHz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="392027251" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="392027251" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2023 21:23:45 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="694440451" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="694440451" Received: from xhh-dg164.sh.intel.com ([10.238.5.169]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2023 21:23:43 -0800 From: "Xiang, Haihao" To: ffmpeg-devel@ffmpeg.org Date: Mon, 30 Jan 2023 13:23:21 +0800 Message-Id: <20230130052321.27566-1-haihao.xiang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang , Anton Khirnov MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Haihao Xiang This is a regression since commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 input_image is freed in vaapi_encode_wait() however it is still used in commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 $ ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i testsrc -vf "format=nv12,hwupload" -c:v h264_vaapi -f null - Note input_image will be freed in vaapi_encode_free() now. Cc: Anton Khirnov Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 6787b90e8d..b644814b6c 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -173,9 +173,6 @@ static int vaapi_encode_wait(AVCodecContext *avctx, } } - // Input is definitely finished with now. - av_frame_free(&pic->input_image); - pic->encode_complete = 1; return 0; } -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".