From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Haihao Xiang <haihao.xiang@intel.com>, Anton Khirnov <anton@khirnov.net>
Subject: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault
Date: Mon, 30 Jan 2023 13:23:21 +0800
Message-ID: <20230130052321.27566-1-haihao.xiang@intel.com> (raw)
From: Haihao Xiang <haihao.xiang@intel.com>
This is a regression since commit fbdba9a1a69fe4df413d9e9df1b11db522946e75
input_image is freed in vaapi_encode_wait() however it is still used in
commit fbdba9a1a69fe4df413d9e9df1b11db522946e75
$ ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i testsrc -vf
"format=nv12,hwupload" -c:v h264_vaapi -f null -
Note input_image will be freed in vaapi_encode_free() now.
Cc: Anton Khirnov <anton@khirnov.net>
Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
libavcodec/vaapi_encode.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c
index 6787b90e8d..b644814b6c 100644
--- a/libavcodec/vaapi_encode.c
+++ b/libavcodec/vaapi_encode.c
@@ -173,9 +173,6 @@ static int vaapi_encode_wait(AVCodecContext *avctx,
}
}
- // Input is definitely finished with now.
- av_frame_free(&pic->input_image);
-
pic->encode_complete = 1;
return 0;
}
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-01-30 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 5:23 Xiang, Haihao [this message]
2023-01-30 7:55 ` Anton Khirnov
2023-01-30 15:15 ` Xiang, Haihao
2023-01-31 13:14 ` [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix propagating durations and opaques Anton Khirnov
2023-02-01 2:59 ` Xiang, Haihao
2023-02-02 2:47 ` Xiang, Haihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130052321.27566-1-haihao.xiang@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=haihao.xiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git