Re: [FFmpeg-devel] [PATCH 1/2] avcodec/utils: use 32pixel alignment for bink

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/utils: use 32pixel alignment for bink
Date: Sat, 28 Jan 2023 20:51:05 +0100
Message-ID: <20230128195105.GH1949656@pb2> (raw)
In-Reply-To: <Y9MT6n/W40ol+/2j@4eb231a0d1b36cedda43a2a005befe4d>

[-- Attachment #1.1: Type: text/plain, Size: 1590 bytes --]

On Fri, Jan 27, 2023 at 10:59:38AM +1100, Peter Ross wrote:
> On Sun, Jan 22, 2023 at 01:02:21AM +0100, Michael Niedermayer wrote:
> > bink supports 16x16 blocks in chroma planes thus we need to allocate enough.
> > Fixes: out of array access
> > Fixes: 55026/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-6013915371012096
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/utils.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> > index 2b63a498b9..87634e3711 100644
> > --- a/libavcodec/utils.c
> > +++ b/libavcodec/utils.c
> > @@ -243,6 +243,8 @@ void avcodec_align_dimensions2(AVCodecContext *s, int *width, int *height,
> >      case AV_PIX_FMT_GBRAP16BE:
> >          w_align = 16; //FIXME assume 16 pixel per macroblock
> >          h_align = 16 * 2; // interlaced needs 2 macroblocks height
> > +        if (s->codec_id == AV_CODEC_ID_BINKVIDEO)
> > +            w_align = 16*2;
> >          break;
> >      case AV_PIX_FMT_YUV411P:
> >      case AV_PIX_FMT_YUVJ411P:
> 
> please apply.

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".