From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D43A34037B for ; Sat, 21 Jan 2023 01:21:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB90F68BD36; Sat, 21 Jan 2023 03:21:09 +0200 (EET) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 39F6168BD0F for ; Sat, 21 Jan 2023 03:21:03 +0200 (EET) Received: by mail-ot1-f41.google.com with SMTP id n24-20020a0568301e9800b006865671a9d5so4088599otr.6 for ; Fri, 20 Jan 2023 17:21:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xWHsMCYx/I0+8/Ml7oqLXQ1IO+AqB52l9BmbWoxVe0s=; b=bLcUvinsvEVSvJkHfuOsH1LIbk4fHOW0dgOQxZvxEwERLlYUbgfxWJkwCu1GnSqfZq GKVdYoBp8PEEXrok6CqG9XEZQLzrYssSv7yzO+nud1n68CvCeuV/2SeHo+1wJRejK+8J VO/oGsxWtSH1gk2FBCumD84B2Hsp5dQgiI0S6ppf1Hh9/l1xqgO1YbJZhCu95KTy/YSv vBeY3nnVEdspXTOXKVQYp+RiPgqe5iE7EiX5jksRMvsyw+UD7SrBgVuGzKw1KUSNLiAn 8wID2mD0ZYxOU15t+nNmZvao4c8c6/YTMLpYlk2VLmCXyDp1s6tX6TpWpjQz8Kp0gCUa sJzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xWHsMCYx/I0+8/Ml7oqLXQ1IO+AqB52l9BmbWoxVe0s=; b=MZRRSwkz+Zi4m504HHiBifJ609KTS4Z9fJobmXOjeKlWDEfhHY3ciy0vTtDT/CNxDw T/HesPw30cydnz/o5dVZmJZUkzv2AsVvw9A1pd58J9eSt0igN+zmyal3CsvxCuy6l5Xl TqKr1dfAgJyIqulKxROdG4W7cXtrZHcZ/j/TEhttB6hmgL5y5yl/EH+coH42YtP3yd76 uf8FzHUTFcbokMwwZIaWiR+pNkUI+eG6pRHGmrhextDjVPitjo0GtCX46oXgsxf4/fwi WVGqI+txWVOQ0QSFNsHoxgb9kUDFHxjZF9fJoFDKA71EniPEXUeHI8xeegN/29j5qXrJ OoHg== X-Gm-Message-State: AFqh2ko30S3hvpY3zxuq3I9bTHv39dsesJHRMxZeh3YQyMT6a7fOOr/a s5khBGPUtFXoSq+sk+ptdICWpITOXNU= X-Google-Smtp-Source: AMrXdXsbrRt4xKRC397UmupeSE6lCPCFCdysDWMrA5WF/y8NPxXLNg2Dd6T5x4mE/s/m+dwaZuhOQg== X-Received: by 2002:a9d:6310:0:b0:686:5397:3388 with SMTP id q16-20020a9d6310000000b0068653973388mr7139749otk.37.1674264060946; Fri, 20 Jan 2023 17:21:00 -0800 (PST) Received: from localhost.localdomain ([2600:1700:4830:3f7f:c873:f470:4828:6b82]) by smtp.gmail.com with ESMTPSA id a2-20020a9d4702000000b006864ccdb053sm6336457otf.26.2023.01.20.17.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 17:21:00 -0800 (PST) From: Cameron Gutman To: ffmpeg-devel@ffmpeg.org Date: Fri, 20 Jan 2023 19:20:30 -0600 Message-Id: <20230121012030.1471-1-aicommander@gmail.com> X-Mailer: git-send-email 2.35.2.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/mfenc: fix double-free on init failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Cameron Gutman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: mfenc sets FF_CODEC_CAP_INIT_CLEANUP, so calling mf_close() on failure inside mf_init() results in a double-free. Signed-off-by: Cameron Gutman --- libavcodec/mfenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 36a6d8482d..f3415df10b 100644 --- a/libavcodec/mfenc.c +++ b/libavcodec/mfenc.c @@ -1214,7 +1214,6 @@ static int mf_init(AVCodecContext *avctx) return 0; } } - mf_close(avctx); return ret; } -- 2.35.2.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".