From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 786F745244 for ; Sun, 15 Jan 2023 16:55:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E82CE68BC53; Sun, 15 Jan 2023 18:55:38 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 632B368BB11 for ; Sun, 15 Jan 2023 18:55:32 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 10D0160009 for ; Sun, 15 Jan 2023 16:55:30 +0000 (UTC) Date: Sun, 15 Jan 2023 17:55:28 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230115165528.GR1949656@pb2> References: <0af7e930-9ec7-dc81-95bc-939eb21e2da0@mediaarea.net> <20230114200452.GQ1949656@pb2> <90886e84-2dff-5e05-6802-ec577a4307ff@mediaarea.net> MIME-Version: 1.0 In-Reply-To: <90886e84-2dff-5e05-6802-ec577a4307ff@mediaarea.net> Subject: Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6927690800183382619==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6927690800183382619== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jTlsQtO0VwrbBARu" Content-Disposition: inline --jTlsQtO0VwrbBARu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 15, 2023 at 03:24:37PM +0100, Jerome Martinez wrote: > On 14/01/2023 21:04, Michael Niedermayer wrote: > > On Sat, Jan 14, 2023 at 04:48:10PM +0100, Jerome Martinez wrote: > > [...] > > > + stored_height =3D (stored_height+15)/16*16; > > If this is supposed to match the actual macroblocks, then this would > > have to consider field pictures and interlacing as it differs from > > progressive >=20 > There is no change on that side, no addition, no change about it, this co= de > is moved, and interlace is already managed in the current code: >=20 > =A0=A0=A0 //Stored height > =A0=A0=A0 mxf_write_local_tag(s, 4, 0x3202); > =A0=A0=A0 avio_wb32(pb, stored_height>>sc->interlaced); > [...] > =A0=A0 //Display height > =A0=A0=A0 mxf_write_local_tag(s, 4, 0x3208); > =A0=A0=A0 avio_wb32(pb, display_height>>sc->interlaced); >=20 > The patch disables the rounding for some formats, it is not intended to > change the behavior for MPEG-2 Video and AVC formats as it seems fine > (FFmpeg has the same behavior as other muxers, at least for MPEG-2 Video, > also for interlaced content). ok thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --jTlsQtO0VwrbBARu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY8Qv9QAKCRBhHseHBAsP qyUpAJ9M7rTCY3HU/CwLhMBqh4GGao8ksgCgkJdZGLu1oTatN7/ZINgJbJqiLro= =66ZZ -----END PGP SIGNATURE----- --jTlsQtO0VwrbBARu-- --===============6927690800183382619== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6927690800183382619==--