From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format
Date: Thu, 5 Jan 2023 21:53:42 +0100
Message-ID: <20230105205342.GE4028235@pb2> (raw)
In-Reply-To: <CAPYw7P4DhGPgcTfDKsN8DV4-_v0K=d-MATMWo8+MXc9xHLM=gw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1156 bytes --]
On Thu, Jan 05, 2023 at 01:44:10PM +0100, Paul B Mahol wrote:
> Patch attached.
> swresample.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> eee7a0685b44aa867562138a2e2437ecb8844612 0001-libswresample-swresample-avoid-s16p-internal-transfe.patch
> From 9c4cd60e2dd41cf98d693c8251f4cfade0807073 Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Thu, 5 Jan 2023 13:40:12 +0100
> Subject: [PATCH] libswresample/swresample: avoid s16p internal transfer format
>
> Instead use float one by default for sample rate conversions.
> The s16p internal transfer format produces visible and hearable
> quantization artifacts.
When does this occur and why?
This change should be limited to the case that benefits, this would force this
even without resampling in some cases.
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The day soldiers stop bringing you their problems is the day you have stopped
leading them. They have either lost confidence that you can help or concluded
you do not care. Either case is a failure of leadership. - Colin Powell
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-01-05 20:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 12:44 Paul B Mahol
2023-01-05 20:53 ` Michael Niedermayer [this message]
2023-01-05 22:08 ` Paul B Mahol
2023-01-06 17:25 ` Michael Niedermayer
2023-01-06 18:01 ` Paul B Mahol
2023-01-06 18:04 ` Paul B Mahol
2023-01-08 14:52 ` Michael Niedermayer
2023-01-08 15:27 ` Paul B Mahol
2023-01-12 14:20 ` Paul B Mahol
2023-01-12 15:41 ` Michael Niedermayer
2023-01-12 16:09 ` Paul B Mahol
2023-01-12 19:49 ` Michael Niedermayer
2023-01-08 14:45 ` Michael Niedermayer
2023-01-08 15:18 ` Paul B Mahol
2023-01-12 15:37 ` Michael Niedermayer
2023-01-09 10:41 ` Tobias Rapp
2023-01-09 12:25 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105205342.GE4028235@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git