From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing
Date: Sat, 31 Dec 2022 20:26:34 +0100
Message-ID: <20221231192634.GA60434@mariano> (raw)
In-Reply-To: <20220713000217.257584-1-stefasab@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote:
> For some samples the pkt->pts is always missing, use the pkt->dts
> instead.
>
> Fix trac issue http://trac.ffmpeg.org/ticket/4427.
> ---
> fftools/ffprobe.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Updated.
[-- Attachment #2: 0001-ffprobe-use-pkt-dts-to-compute-interval-ts-when-pts-.patch --]
[-- Type: text/x-diff, Size: 1228 bytes --]
From 3788035aade64f322f31bd139da8c281a15fa611 Mon Sep 17 00:00:00 2001
From: Stefano Sabatini <stefasab@gmail.com>
Date: Wed, 13 Jul 2022 01:28:33 +0200
Subject: [PATCH 1/2] ffprobe: use pkt->dts to compute interval ts when pts is
missing
For some samples the pkt->pts is always missing, use the pkt->dts
instead.
Fix trac issue http://trac.ffmpeg.org/ticket/4427.
---
fftools/ffprobe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index d2f126d9d6..cd824f5ad1 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2859,9 +2859,10 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile,
}
if (selected_streams[pkt->stream_index]) {
AVRational tb = ifile->streams[pkt->stream_index].st->time_base;
+ int64_t pts = pkt->pts != AV_NOPTS_VALUE ? pkt->pts : pkt->dts;
- if (pkt->pts != AV_NOPTS_VALUE)
- *cur_ts = av_rescale_q(pkt->pts, tb, AV_TIME_BASE_Q);
+ if (pts != AV_NOPTS_VALUE)
+ *cur_ts = av_rescale_q(pts, tb, AV_TIME_BASE_Q);
if (!has_start && *cur_ts != AV_NOPTS_VALUE) {
start = *cur_ts;
--
2.25.1
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-31 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 0:02 Stefano Sabatini
2022-12-31 19:26 ` Stefano Sabatini [this message]
2023-01-15 1:25 ` Stefano Sabatini
2023-01-15 17:05 ` Michael Niedermayer
2023-01-16 3:01 ` "zhilizhao(赵志立)"
2023-01-16 23:41 ` Stefano Sabatini
2023-01-17 2:57 ` "zhilizhao(赵志立)"
2023-01-25 0:19 ` Stefano Sabatini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221231192634.GA60434@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git