From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2372044110 for ; Tue, 27 Dec 2022 21:49:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 82A3A68BBD3; Tue, 27 Dec 2022 23:49:26 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02FD068A360 for ; Tue, 27 Dec 2022 23:49:20 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 1DD7A40007 for ; Tue, 27 Dec 2022 21:49:19 +0000 (UTC) Date: Tue, 27 Dec 2022 22:49:19 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221227214919.GT3806951@pb2> References: <20221224225034.449-1-michael@niedermayer.cc> <1c82e874dde362f5a45c77fbb265ff600a895436.camel@haerdin.se> <20221226215412.GP3806951@pb2> <5b588572-8983-729f-2456-f6f756a76f26@passwd.hu> MIME-Version: 1.0 In-Reply-To: <5b588572-8983-729f-2456-f6f756a76f26@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5539733057953576478==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5539733057953576478== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jG6qxyIkAZdnv/nT" Content-Disposition: inline --jG6qxyIkAZdnv/nT Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: >=20 >=20 > On Mon, 26 Dec 2022, Michael Niedermayer wrote: >=20 > > On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas H=E4rdin wrote: > > > l=F6r 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer: > > > >=20 > > > > =A0=A0=A0=A0=A0=A0=A0=A0 index_table->nb_ptses +=3D s->index_durati= on; > > > > +=A0=A0=A0=A0=A0=A0=A0 // If index_duration is substantially larger= than > > > > nb_index_entries then this algorithm which > > > > +=A0=A0=A0=A0=A0=A0=A0 // allocates index_duration elements is a ba= d idea. All > > > > files i tried have it equal > > > > +=A0=A0=A0=A0=A0=A0=A0 if (s->index_duration > 10LL * s->nb_index_e= ntries) > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return AVERROR_PATCHWELCOME; > > >=20 > > > I was going to say this can overflow but the 10LL ensures it can't. So > > > looks OK. > >=20 > > will apply >=20 > Please don't, as far as I see this disallows the usage of partial index > tables, so practically rejecting valid files, which is not OK. can you share a file that would break ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --jG6qxyIkAZdnv/nT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY6toXwAKCRBhHseHBAsP q+BwAKCQJE1IjV3y3zx4ydiEDB4Xu/nXRQCeIFWJRoPFQtW9Xm8Yedd0boDvAU4= =snmz -----END PGP SIGNATURE----- --jG6qxyIkAZdnv/nT-- --===============5539733057953576478== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5539733057953576478==--