Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1378 bytes --]

On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote:
> 
> 
> On Mon, 26 Dec 2022, Michael Niedermayer wrote:
> 
> > On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote:
> > > lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer:
> > > > 
> > > >          index_table->nb_ptses += s->index_duration;
> > > > +        // If index_duration is substantially larger than
> > > > nb_index_entries then this algorithm which
> > > > +        // allocates index_duration elements is a bad idea. All
> > > > files i tried have it equal
> > > > +        if (s->index_duration > 10LL * s->nb_index_entries)
> > > > +            return AVERROR_PATCHWELCOME;
> > > 
> > > I was going to say this can overflow but the 10LL ensures it can't. So
> > > looks OK.
> > 
> > will apply
> 
> Please don't, as far as I see this disallows the usage of partial index
> tables, so practically rejecting valid files, which is not OK.

can you share a file that would break ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".