From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B8C44407A9 for ; Tue, 27 Dec 2022 19:49:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70D0E68BAB3; Tue, 27 Dec 2022 21:49:23 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6397268A215 for ; Tue, 27 Dec 2022 21:49:16 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 8AB91C0007 for ; Tue, 27 Dec 2022 19:49:14 +0000 (UTC) Date: Tue, 27 Dec 2022 20:49:13 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221227194913.GR3806951@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6433598504702723033==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6433598504702723033== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0V0QeVRG5zYX4NDS" Content-Disposition: inline --0V0QeVRG5zYX4NDS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 26, 2022 at 01:07:51PM +0000, Wujian(Chin) wrote: > The issue has been modified. Please review again, thank you! >=20 > Signed-off-by: wujian_nanjing > --- > doc/fftools-common-opts.texi | 11 +++++++ > fftools/cmdutils.c | 77 ++++++++++++++++++++++++++++++++++++++= ++++-- > fftools/cmdutils.h | 25 ++++++++++++++ > fftools/ffmpeg.c | 10 +++--- > fftools/ffplay.c | 9 ++++-- > fftools/ffprobe.c | 10 +++--- > 6 files changed, 128 insertions(+), 14 deletions(-) ffmpeg -h segfaults with this patch =3D=3D32366=3D=3D Invalid read of size 8 =3D=3D32366=3D=3D at 0x30836B: split_commandline (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D by 0x3039CD: ffmpeg_parse_options (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D by 0x2ED201: main (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D Address 0x2ced5290 is 0 bytes after a block of size 16 a= lloc'd =3D=3D32366=3D=3D at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload= _memcheck-amd64-linux.so) =3D=3D32366=3D=3D by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgp= reload_memcheck-amd64-linux.so) =3D=3D32366=3D=3D by 0x116B322: av_malloc (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D by 0x116B4D8: av_mallocz (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D by 0x306469: copy_argv (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D by 0x306537: handle_arg_param (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D by 0x2ED1F5: main (in ffmpeg/ffmpeg_g) =3D=3D32366=3D=3D=20 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus --0V0QeVRG5zYX4NDS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY6tMMgAKCRBhHseHBAsP q8AaAJ9UADJpVk6UJXRP4Pika128TZ9orgCfaT1NR+dltMv/uoagd/eDo2TGnd8= =yXso -----END PGP SIGNATURE----- --0V0QeVRG5zYX4NDS-- --===============6433598504702723033== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6433598504702723033==--