From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 69E2544E01 for ; Mon, 26 Dec 2022 21:54:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FA3A68BBCC; Mon, 26 Dec 2022 23:54:20 +0200 (EET) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE22968B3E9 for ; Mon, 26 Dec 2022 23:54:13 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 028DE240003 for ; Mon, 26 Dec 2022 21:54:12 +0000 (UTC) Date: Mon, 26 Dec 2022 22:54:12 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221226215412.GP3806951@pb2> References: <20221224225034.449-1-michael@niedermayer.cc> <1c82e874dde362f5a45c77fbb265ff600a895436.camel@haerdin.se> MIME-Version: 1.0 In-Reply-To: <1c82e874dde362f5a45c77fbb265ff600a895436.camel@haerdin.se> Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1266099092888890148==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1266099092888890148== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i+yzTqNyNhelWXoM" Content-Disposition: inline --i+yzTqNyNhelWXoM Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas H=E4rdin wrote: > l=F6r 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer: > >=20 > > =A0=A0=A0=A0=A0=A0=A0=A0 index_table->nb_ptses +=3D s->index_duration; > > +=A0=A0=A0=A0=A0=A0=A0 // If index_duration is substantially larger than > > nb_index_entries then this algorithm which > > +=A0=A0=A0=A0=A0=A0=A0 // allocates index_duration elements is a bad id= ea. All > > files i tried have it equal > > +=A0=A0=A0=A0=A0=A0=A0 if (s->index_duration > 10LL * s->nb_index_entri= es) > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return AVERROR_PATCHWELCOME; >=20 > I was going to say this can overflow but the 10LL ensures it can't. So > looks OK. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew .= =2E." --i+yzTqNyNhelWXoM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY6oYAwAKCRBhHseHBAsP qyCLAJ9+NsnjKphlI8BhnGidaa9MKMA7rACgho9SwnOvJUidI0+DMZ9t2l2JTNc= =nFue -----END PGP SIGNATURE----- --i+yzTqNyNhelWXoM-- --===============1266099092888890148== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1266099092888890148==--