From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C14FD40616 for ; Sat, 24 Dec 2022 19:29:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5E25168B263; Sat, 24 Dec 2022 21:29:35 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 228DB68BA06 for ; Sat, 24 Dec 2022 21:29:27 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id C919440002 for ; Sat, 24 Dec 2022 19:29:26 +0000 (UTC) Date: Sat, 24 Dec 2022 20:29:25 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221224192925.GJ3806951@pb2> References: <20221223212245.19169-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Remove this_partition X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3709721857475409852==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3709721857475409852== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TsHlYwxJd0kekxFz" Content-Disposition: inline --TsHlYwxJd0kekxFz Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 23, 2022 at 11:01:55PM +0100, Marton Balint wrote: >=20 >=20 > On Fri, 23 Dec 2022, Michael Niedermayer wrote: >=20 > > Suggested-by: Tomas H=E4rdin > >=20 > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mxfdec.c | 37 +++++++++++++++++++++++-------------- > > 1 file changed, 23 insertions(+), 14 deletions(-) >=20 > this_partition should be =3D=3D pack_ofs - run_in, not pack_ofs + run_in. >=20 [...] > > @@ -887,7 +896,7 @@ static int mxf_read_partition_pack(void *arg, AVIOC= ontext *pb, int tag, int size > > return 0; > > } > >=20 > > -static uint64_t partition_score(MXFPartition *p) > > +static uint64_t partition_score(MXFContext *mxf, MXFPartition *p) > > { > > uint64_t score; > > if (!p) > > @@ -900,7 +909,7 @@ static uint64_t partition_score(MXFPartition *p) > > score =3D 3; > > else > > score =3D 1; > > - return (score << 60) | ((uint64_t)p->this_partition >> 4); > > + return (score << 60) | ((uint64_t)p->pack_ofs + mxf->run_in >> 4); > > } >=20 > You can use pack_ofs here directly instead of this_partition, so the > function prototype does not have to be changed. ok will repost with these 2 changes thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 2 "100% positive feedback" - "All either got their money back or didnt compla= in" "Best seller ever, very honest" - "Seller refunded buyer after failed scam" --TsHlYwxJd0kekxFz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY6dTDgAKCRBhHseHBAsP q4SdAJwLzidnCKTe3rxKaFdUSEXMO1QiQgCfWRHSi62Pe5xnzMlFZkDg9vlEHMY= =Vp4z -----END PGP SIGNATURE----- --TsHlYwxJd0kekxFz-- --===============3709721857475409852== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3709721857475409852==--