Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Remove this_partition

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1524 bytes --]

On Fri, Dec 23, 2022 at 11:01:55PM +0100, Marton Balint wrote:
> 
> 
> On Fri, 23 Dec 2022, Michael Niedermayer wrote:
> 
> > Suggested-by: Tomas Härdin <git@haerdin.se>
> > 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > libavformat/mxfdec.c | 37 +++++++++++++++++++++++--------------
> > 1 file changed, 23 insertions(+), 14 deletions(-)
> 
> this_partition should be == pack_ofs - run_in, not pack_ofs + run_in.
> 
[...]
> > @@ -887,7 +896,7 @@ static int mxf_read_partition_pack(void *arg, AVIOContext *pb, int tag, int size
> >     return 0;
> > }
> > 
> > -static uint64_t partition_score(MXFPartition *p)
> > +static uint64_t partition_score(MXFContext *mxf, MXFPartition *p)
> > {
> >     uint64_t score;
> >     if (!p)
> > @@ -900,7 +909,7 @@ static uint64_t partition_score(MXFPartition *p)
> >         score = 3;
> >     else
> >         score = 1;
> > -    return (score << 60) | ((uint64_t)p->this_partition >> 4);
> > +    return (score << 60) | ((uint64_t)p->pack_ofs + mxf->run_in >> 4);
> > }
> 
> You can use pack_ofs here directly instead of this_partition, so the
> function prototype does not have to be changed.

ok will repost with these 2 changes

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".