From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1254E44D38 for ; Tue, 20 Dec 2022 17:13:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEF4668BA05; Tue, 20 Dec 2022 19:13:55 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4306A687FB9 for ; Tue, 20 Dec 2022 19:13:49 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 677501C0002 for ; Tue, 20 Dec 2022 17:13:47 +0000 (UTC) Date: Tue, 20 Dec 2022 18:13:47 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221220171347.GB3806951@pb2> References: <20221218170823.32130-1-michael@niedermayer.cc> <20221218170823.32130-3-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/apac: Sanity check bits_per_coded_sample X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3846145360902518056==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3846145360902518056== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZATCr4BkWovzAAkA" Content-Disposition: inline --ZATCr4BkWovzAAkA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 19, 2022 at 08:35:45PM +0100, Paul B Mahol wrote: > On 12/18/22, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in= type > > 'int' > > Fixes: > > 53931/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APAC_fuzzer-607= 2913738727424 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/apac.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/apac.c b/libavcodec/apac.c > > index 030f81adce..2501209681 100644 > > --- a/libavcodec/apac.c > > +++ b/libavcodec/apac.c > > @@ -75,7 +75,9 @@ static av_cold int apac_init(AVCodecContext *avctx) > > avctx->sample_fmt =3D AV_SAMPLE_FMT_U8P; > > > > if (avctx->ch_layout.nb_channels < 1 || > > - avctx->ch_layout.nb_channels > 2) > > + avctx->ch_layout.nb_channels > 2 || > > + avctx->bits_per_coded_sample > 32U > > + ) > > return AVERROR_INVALIDDATA; > > > > for (int ch =3D 0; ch < avctx->ch_layout.nb_channels; ch++) { > > -- > > 2.17.1 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > >=20 > Pretty sure bps cant be <8 and >16 ok, will apply <8 || >16 check then thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri --ZATCr4BkWovzAAkA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY6HtOgAKCRBhHseHBAsP qxNOAJ94lVK7kvx5FcBcgBjfCLSwU+5oTgCdFm7ZacRFvbbjVCcUPDTK8Leann4= =1xVG -----END PGP SIGNATURE----- --ZATCr4BkWovzAAkA-- --===============3846145360902518056== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3846145360902518056==--