From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 3/5] avcodec/apac: Sanity check bits_per_coded_sample
Date: Sun, 18 Dec 2022 18:08:21 +0100
Message-ID: <20221218170823.32130-3-michael@niedermayer.cc> (raw)
In-Reply-To: <20221218170823.32130-1-michael@niedermayer.cc>
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
Fixes: 53931/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APAC_fuzzer-6072913738727424
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/apac.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/apac.c b/libavcodec/apac.c
index 030f81adce..2501209681 100644
--- a/libavcodec/apac.c
+++ b/libavcodec/apac.c
@@ -75,7 +75,9 @@ static av_cold int apac_init(AVCodecContext *avctx)
avctx->sample_fmt = AV_SAMPLE_FMT_U8P;
if (avctx->ch_layout.nb_channels < 1 ||
- avctx->ch_layout.nb_channels > 2)
+ avctx->ch_layout.nb_channels > 2 ||
+ avctx->bits_per_coded_sample > 32U
+ )
return AVERROR_INVALIDDATA;
for (int ch = 0; ch < avctx->ch_layout.nb_channels; ch++) {
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-18 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 17:08 [FFmpeg-devel] [PATCH 1/5] avcodec/tiff: Check camera_calibration for 0 Michael Niedermayer
2022-12-18 17:08 ` [FFmpeg-devel] [PATCH 2/5] avcodec/tiff: Prettify code in dng_blit() Michael Niedermayer
2023-01-11 10:30 ` Michael Niedermayer
2022-12-18 17:08 ` Michael Niedermayer [this message]
2022-12-19 19:35 ` [FFmpeg-devel] [PATCH 3/5] avcodec/apac: Sanity check bits_per_coded_sample Paul B Mahol
2022-12-20 17:13 ` Michael Niedermayer
2022-12-18 17:08 ` [FFmpeg-devel] [PATCH 4/5] avcodec/h264_slice: Use unsigned for fgs seed computation Michael Niedermayer
2023-01-11 10:32 ` Michael Niedermayer
2022-12-18 17:08 ` [FFmpeg-devel] [PATCH 5/5] avcodec/wavpack: Avoid undefined shift in get_tail() Michael Niedermayer
2022-12-18 17:18 ` James Almer
2022-12-18 17:32 ` Andreas Rheinhardt
2022-12-18 18:14 ` Paul B Mahol
2022-12-20 16:42 ` Michael Niedermayer
2023-01-11 10:29 ` [FFmpeg-devel] [PATCH 1/5] avcodec/tiff: Check camera_calibration for 0 Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221218170823.32130-3-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git