Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2927 bytes --]

On Thu, Dec 15, 2022 at 02:11:28AM +0100, Lynne wrote:
> Dec 14, 2022, 22:45 by michael@niedermayer.cc:
> 
> > On Tue, Dec 13, 2022 at 07:42:23PM +0100, Lynne wrote:
> >
> >> Dec 13, 2022, 13:22 by d.kozinski@samsung.com:
> >>
> >> > We made some changes in our EVC wrapper implementation and would like to
> >> > submit new patches to patchwork, but it's still unclear to me how to deal
> >> > with the MAINTAINERS file. 
> >> >
> >> > Should I leave the following lines:
> >> > +  libxevd.c                             Dawid Kozinski
> >> > +  libxeve.c,                            Dawid Kozinski
> >> > +  evc.c, evc.h                        Dawid Kozinski
> >> > +  evcdec.c                             Dawid Kozinski
> >> > +  evc_parser.c                      Dawid Kozinski
> >> >
> >> > or should I remove them?
> >> >
> >> > We are expecting a clear and consistent standpoint on this matter.
> >> >
> >>
> >> Get rid of them. Michael has made it clear anyone on the list
> >> must have commit rights. I'm not for blocking anyone from having
> >> commit rights, but you've made zero contributions to the project
> >> so far, and maintaining requires some level of dedication.
> >>
> >
> > You surely have the right to object to Dawid having commit rights.
> > And i understand your argument why, but that has nothing to do with
> > me or the list. There are people on the MAINTAINERS list who do not
> > have commit rights.
> > for example the developers who i presume are paid by loongson to maintain 
> > the mips/loongson code do not currently have commit right.
> > Seems a similar case to me
> >
> 
> You're making assumptions. You've said that anyone who's on maintainers
> needs push rights. Then you said that unless someone explicitly asks not to
> get push rights, they will if they're added to maintainers. Right now, the
> person hasn't said anything, yet you're assuming he doesn't want push rights.

There are many reasons why someone in MAINTAINERS might have no push access
* lack of git knowledge
* explicitly asked not to receive git write
* messy patches submitted in the past
* simply forgotten
* a past reason which was not noticed that it no longer is true

Once Dawids patches are applied, it will be easy to judge their quality
based on the changes which where asked for in the review.

One developer objected to Dawid having write access currently. If it was
not for that i would tend toward giving Dawid write access if he wants to
maintain the code. 
If he personally wants to maintain it or if he is paid to maintain it
doesnt really matter. Whoever maintains code benefits from being able
to change said code.

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".