From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A362B44F9D for ; Tue, 13 Dec 2022 18:17:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E474E68BBC9; Tue, 13 Dec 2022 20:17:50 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A5A3268BAF5 for ; Tue, 13 Dec 2022 20:17:44 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id B85FA40004 for ; Tue, 13 Dec 2022 18:17:43 +0000 (UTC) Date: Tue, 13 Dec 2022 19:17:42 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221213181742.GK3806951@pb2> References: <20221209234636.GH3806951@pb2> <20221212214210.2628-1-timo@rothenpieler.org> MIME-Version: 1.0 In-Reply-To: <20221212214210.2628-1-timo@rothenpieler.org> Subject: Re: [FFmpeg-devel] [PATCH v5 1/2] lavc: convert frame threading to the receive_frame() pattern X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4498414034636871794==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4498414034636871794== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hu1ClgjWvfumRnAp" Content-Disposition: inline --hu1ClgjWvfumRnAp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 12, 2022 at 10:42:09PM +0100, Timo Rothenpieler wrote: > From: Anton Khirnov >=20 > Reorganize the code such that the frame threading code does not call the > decoders directly, but instead calls back into the generic decoding > code. This avoids duplicating the logic that wraps the decoder > invocation and will be useful in the following commits. > --- > libavcodec/decode.c | 62 ++++++--- > libavcodec/decode.h | 7 + > libavcodec/internal.h | 7 + > libavcodec/pthread_frame.c | 265 ++++++++++++++++++++++++------------- > libavcodec/thread.h | 18 +-- > 5 files changed, 236 insertions(+), 123 deletions(-) this breaks some files=20 but seems not 100% reproduceable this is what i see after the patch when it fails: [ogg @ 0x56170f3d67c0] Broken file, keyframe not correctly marked.peed=3D 2= 42x =20 Error while decoding stream #0:1: Operation not permitted Last message repeated 128784 times Error while decoding stream #0:1: Operation not permittedate=3DN/A speed=3D= 9.94x =20 Last message repeated 118013 times Error while decoding stream #0:1: Operation not permittedate=3DN/A speed=3D= 4.98x =20 Last message repeated 131881 times Error while decoding stream #0:1: Operation not permittedate=3DN/A speed=3D= 3.32x =20 Last message repeated 131490 times Error while decoding stream #0:1: Operation not permittedate=3DN/A speed=3D= 2.49x =20 Last message repeated 26968 times frame=3D 106 fps=3D 50 q=3D-0.0 Lsize=3DN/A time=3D00:00:04.98 bitrate=3DN= /A speed=3D2.37x =20 video:50kB audio:215kB subtitle:0kB other streams:0kB global headers:0kB mu= xing overhead: unknown Exiting normally, received signal 2. i will mail you the file privatly thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle --hu1ClgjWvfumRnAp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY5jBwAAKCRBhHseHBAsP q0etAKCUqlsMOJvihvUVsIxvrELAj5GvlwCeOXEj+JtP8xEIQ8u0oBrVuM5Okks= =N79O -----END PGP SIGNATURE----- --hu1ClgjWvfumRnAp-- --===============4498414034636871794== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4498414034636871794==--