From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E3E9744F2F for ; Fri, 9 Dec 2022 16:17:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B495368BD0D; Fri, 9 Dec 2022 18:17:25 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B5FCF68B579 for ; Fri, 9 Dec 2022 18:17:19 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 0048D10000C for ; Fri, 9 Dec 2022 16:17:17 +0000 (UTC) Date: Fri, 9 Dec 2022 17:17:16 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221209161716.GE3806951@pb2> References: <20221207114330.250-1-timo@rothenpieler.org> <20221207132023.896-1-timo@rothenpieler.org> <20221207222211.GC3806951@pb2> <0c60d40d-9df8-cba8-257f-6fe4a66d854a@rothenpieler.org> MIME-Version: 1.0 In-Reply-To: <0c60d40d-9df8-cba8-257f-6fe4a66d854a@rothenpieler.org> Subject: Re: [FFmpeg-devel] [PATCH v3] lavc: convert frame threading to the receive_frame() pattern X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1405946441791748669==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1405946441791748669== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vAr1W/eR4LdSeo08" Content-Disposition: inline --vAr1W/eR4LdSeo08 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 09, 2022 at 02:09:45PM +0100, Timo Rothenpieler wrote: > On 07/12/2022 23:22, Michael Niedermayer wrote: > > On Wed, Dec 07, 2022 at 02:20:23PM +0100, Timo Rothenpieler wrote: > > > From: Anton Khirnov > > >=20 > > > Reorganize the code such that the frame threading code does not call = the > > > decoders directly, but instead calls back into the generic decoding > > > code. This avoids duplicating the logic that wraps the decoder > > > invocation and will be useful in the following commits. > > > --- > > > libavcodec/decode.c | 57 +++++---- > > > libavcodec/decode.h | 7 + > > > libavcodec/internal.h | 7 + > > > libavcodec/pthread_frame.c | 256 ++++++++++++++++++++++++----------= --- > > > libavcodec/thread.h | 18 +-- > > > 5 files changed, 222 insertions(+), 123 deletions(-) > >=20 > > This breaks on arm (probably lack of pthread support) in this env > >=20 > > libavcodec/libavcodec.a(decode.o): In function `decode_receive_frame_in= ternal': > > arm/src/libavcodec/decode.c:616: undefined reference to `ff_thread_rece= ive_frame' > > arm/src/libavcodec/decode.c:616: undefined reference to `ff_thread_rece= ive_frame' > > collect2: error: ld returned 1 exit status > > Makefile:131: recipe for target 'ffprobe_g' failed > > make: *** [ffprobe_g] Error 1 >=20 > Probably just missing an #if somewhere. > Why does arm not support pthreads though? > Or is that just this specific configuration? just this specific environment=20 i could fix that but then noone will test the lack of pthreads so i think its better if i leave it :) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has disposed of foreign enemies by conquest or treaty, and there is nothing more to fear from them, then he is always stirring up some war or other, in order that the people may require a leader. -- Plato --vAr1W/eR4LdSeo08 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY5NfgwAKCRBhHseHBAsP q10gAJ47rY7Grve7bHjyPtkAqE/OfehIlACeIs7xBI0ao8HFe1lsCnkcmzlR5yQ= =qgcF -----END PGP SIGNATURE----- --vAr1W/eR4LdSeo08-- --===============1405946441791748669== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1405946441791748669==--