From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 83D3544F03 for ; Wed, 7 Dec 2022 22:22:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 91EE268B44A; Thu, 8 Dec 2022 00:22:19 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34D8A68A771 for ; Thu, 8 Dec 2022 00:22:13 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 519FA60007 for ; Wed, 7 Dec 2022 22:22:12 +0000 (UTC) Date: Wed, 7 Dec 2022 23:22:11 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221207222211.GC3806951@pb2> References: <20221207114330.250-1-timo@rothenpieler.org> <20221207132023.896-1-timo@rothenpieler.org> MIME-Version: 1.0 In-Reply-To: <20221207132023.896-1-timo@rothenpieler.org> Subject: Re: [FFmpeg-devel] [PATCH v3] lavc: convert frame threading to the receive_frame() pattern X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0854644724418846363==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0854644724418846363== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gRZ38brEgCoUohoa" Content-Disposition: inline --gRZ38brEgCoUohoa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 07, 2022 at 02:20:23PM +0100, Timo Rothenpieler wrote: > From: Anton Khirnov >=20 > Reorganize the code such that the frame threading code does not call the > decoders directly, but instead calls back into the generic decoding > code. This avoids duplicating the logic that wraps the decoder > invocation and will be useful in the following commits. > --- > libavcodec/decode.c | 57 +++++---- > libavcodec/decode.h | 7 + > libavcodec/internal.h | 7 + > libavcodec/pthread_frame.c | 256 ++++++++++++++++++++++++------------- > libavcodec/thread.h | 18 +-- > 5 files changed, 222 insertions(+), 123 deletions(-) This breaks on arm (probably lack of pthread support) in this env libavcodec/libavcodec.a(decode.o): In function `decode_receive_frame_intern= al': arm/src/libavcodec/decode.c:616: undefined reference to `ff_thread_receive_= frame' arm/src/libavcodec/decode.c:616: undefined reference to `ff_thread_receive_= frame' collect2: error: ld returned 1 exit status Makefile:131: recipe for target 'ffprobe_g' failed make: *** [ffprobe_g] Error 1 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf --gRZ38brEgCoUohoa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY5ESDAAKCRBhHseHBAsP q4GsAJ9DP/Zza0HrGlef/CdDC8bcd5LcYACggU2s0Ozi17D8hwYGMaRSEQY12lo= =Ox0Z -----END PGP SIGNATURE----- --gRZ38brEgCoUohoa-- --===============0854644724418846363== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0854644724418846363==--