From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] lavc: convert frame threading to the receive_frame() pattern
Date: Wed, 7 Dec 2022 23:22:11 +0100
Message-ID: <20221207222211.GC3806951@pb2> (raw)
In-Reply-To: <20221207132023.896-1-timo@rothenpieler.org>
[-- Attachment #1.1: Type: text/plain, Size: 1435 bytes --]
On Wed, Dec 07, 2022 at 02:20:23PM +0100, Timo Rothenpieler wrote:
> From: Anton Khirnov <anton@khirnov.net>
>
> Reorganize the code such that the frame threading code does not call the
> decoders directly, but instead calls back into the generic decoding
> code. This avoids duplicating the logic that wraps the decoder
> invocation and will be useful in the following commits.
> ---
> libavcodec/decode.c | 57 +++++----
> libavcodec/decode.h | 7 +
> libavcodec/internal.h | 7 +
> libavcodec/pthread_frame.c | 256 ++++++++++++++++++++++++-------------
> libavcodec/thread.h | 18 +--
> 5 files changed, 222 insertions(+), 123 deletions(-)
This breaks on arm (probably lack of pthread support) in this env
libavcodec/libavcodec.a(decode.o): In function `decode_receive_frame_internal':
arm/src/libavcodec/decode.c:616: undefined reference to `ff_thread_receive_frame'
arm/src/libavcodec/decode.c:616: undefined reference to `ff_thread_receive_frame'
collect2: error: ld returned 1 exit status
Makefile:131: recipe for target 'ffprobe_g' failed
make: *** [ffprobe_g] Error 1
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-07 22:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 11:43 [FFmpeg-devel] [PATCH 1/2] " Timo Rothenpieler
2022-12-07 11:43 ` [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: add support for frame threading Timo Rothenpieler
2022-12-07 13:14 ` [FFmpeg-devel] [PATCH v2] lavc: convert frame threading to the receive_frame() pattern Timo Rothenpieler
2022-12-07 13:20 ` [FFmpeg-devel] [PATCH v3] " Timo Rothenpieler
2022-12-07 22:22 ` Michael Niedermayer [this message]
2022-12-09 13:09 ` Timo Rothenpieler
2022-12-09 13:11 ` James Almer
2022-12-09 16:17 ` Michael Niedermayer
2022-12-09 13:37 ` [FFmpeg-devel] [PATCH v4] " Timo Rothenpieler
2022-12-09 23:46 ` Michael Niedermayer
2022-12-10 20:10 ` Timo Rothenpieler
2022-12-11 16:29 ` Michael Niedermayer
2022-12-12 21:42 ` [FFmpeg-devel] [PATCH v5 1/2] " Timo Rothenpieler
2022-12-12 21:42 ` [FFmpeg-devel] [PATCH v5 2/2] avcodec/mjpegdec: add support for frame threading Timo Rothenpieler
2022-12-13 18:17 ` [FFmpeg-devel] [PATCH v5 1/2] lavc: convert frame threading to the receive_frame() pattern Michael Niedermayer
2022-12-14 1:50 ` [FFmpeg-devel] [PATCH v6] " Timo Rothenpieler
2022-12-15 22:10 ` Michael Niedermayer
2022-12-19 11:37 ` Timo Rothenpieler
2022-12-20 11:45 ` Andreas Rheinhardt
2022-12-20 16:06 ` Timo Rothenpieler
2022-12-20 16:15 ` James Almer
2022-12-21 14:22 ` [FFmpeg-devel] [PATCH v7 1/2] " Timo Rothenpieler
2022-12-21 14:22 ` [FFmpeg-devel] [PATCH v7 2/2] avcodec/mjpegdec: add support for frame threading Timo Rothenpieler
2022-12-21 21:35 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207222211.GC3806951@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git