From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 407374429B for ; Mon, 5 Dec 2022 21:27:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8017568BCAA; Mon, 5 Dec 2022 23:27:06 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BF0968BB48 for ; Mon, 5 Dec 2022 23:27:00 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 5F2201BF207 for ; Mon, 5 Dec 2022 21:26:59 +0000 (UTC) Date: Mon, 5 Dec 2022 22:26:58 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221205212658.GZ3806951@pb2> References: <20221204215227.4186-1-jamrial@gmail.com> <20221204215227.4186-2-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20221204215227.4186-2-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 2/5] Revert "avcodec/decode: use a packet list to store packet properties" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2849261733747278816==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2849261733747278816== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KZQuPInE688wxjG+" Content-Disposition: inline --KZQuPInE688wxjG+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 04, 2022 at 06:52:24PM -0300, James Almer wrote: > The idea behind last_pkt_props was to store the properties of the last pa= cket > fed to the decoder. Any sort of queueing required by decoders that consume > several packets before they start outputting frames should be done by the > decoders in question. An example of this is in the libdav1d wrapper. >=20 > This is required to maintain its contents during flush, and for the follo= wing > commits that will fix last_pkt_props in frame threading scenarios. >=20 > This revers commit 022a12b306ab2096e6ac9fc9b149828a849d65b2. >=20 > Signed-off-by: James Almer > --- > libavcodec/avcodec.c | 10 --------- > libavcodec/decode.c | 47 ++++++----------------------------------- > libavcodec/internal.h | 1 - > tests/ref/fate/flcl1905 | 2 +- > 4 files changed, 8 insertions(+), 52 deletions(-) This causes a wrong looking final timestamps for example with V-codecs/WMVP/Arlington.wmv =2E/ffmpeg -i Arlington.wmv -f framecrc - 0, 4410, 4410, 1, 115200, 0x12ea3f01 0, 4411, 4411, 1, 115200, 0xb376241c 1, 8105977, 8105977, 10240, 40960, 0xbbacee03 +1, 8105977, 8105977, 2048, 8192, 0x985d6153 0, 4412, 4412, 1, 115200, 0xc214049c 0, 4413, 4413, 1, 115200, 0xcdcddf9c 0, 4414, 4414, 1, 115200, 0xcbd5c21d 0, 4415, 4415, 1, 115200, 0xed32b414 -1, 8116217, 8116217, 2048, 8192, 0x985d6153 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Homeopathy is like voting while filling the ballot out with transparent ink. Sometimes the outcome one wanted occurs. Rarely its worse than filling out a ballot properly. --KZQuPInE688wxjG+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY45iGwAKCRBhHseHBAsP q9gyAJ9C0AQohbXs+3XZJEB+xXokdH/aVQCdHMQXvb6KnPtzq14r5p0I09Hi/aI= =s2yu -----END PGP SIGNATURE----- --KZQuPInE688wxjG+-- --===============2849261733747278816== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2849261733747278816==--