Re: [FFmpeg-devel] [PATCH 2/5] Revert "avcodec/decode: use a packet list to store packet properties"

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1840 bytes --]

On Sun, Dec 04, 2022 at 06:52:24PM -0300, James Almer wrote:
> The idea behind last_pkt_props was to store the properties of the last packet
> fed to the decoder. Any sort of queueing required by decoders that consume
> several packets before they start outputting frames should be done by the
> decoders in question. An example of this is in the libdav1d wrapper.
> 
> This is required to maintain its contents during flush, and for the following
> commits that will fix last_pkt_props in frame threading scenarios.
> 
> This revers commit 022a12b306ab2096e6ac9fc9b149828a849d65b2.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/avcodec.c    | 10 ---------
>  libavcodec/decode.c     | 47 ++++++-----------------------------------
>  libavcodec/internal.h   |  1 -
>  tests/ref/fate/flcl1905 |  2 +-
>  4 files changed, 8 insertions(+), 52 deletions(-)

This causes a wrong looking final timestamps
for example with V-codecs/WMVP/Arlington.wmv
./ffmpeg -i Arlington.wmv  -f framecrc -

 0,       4410,       4410,        1,   115200, 0x12ea3f01
 0,       4411,       4411,        1,   115200, 0xb376241c
 1,    8105977,    8105977,    10240,    40960, 0xbbacee03
+1,    8105977,    8105977,     2048,     8192, 0x985d6153
 0,       4412,       4412,        1,   115200, 0xc214049c
 0,       4413,       4413,        1,   115200, 0xcdcddf9c
 0,       4414,       4414,        1,   115200, 0xcbd5c21d
 0,       4415,       4415,        1,   115200, 0xed32b414
-1,    8116217,    8116217,     2048,     8192, 0x985d6153


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Homeopathy is like voting while filling the ballot out with transparent ink.
Sometimes the outcome one wanted occurs. Rarely its worse than filling out
a ballot properly.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".