From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E8D5740B13 for ; Fri, 2 Dec 2022 23:11:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BA8268B413; Sat, 3 Dec 2022 01:11:09 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 429B868B22C for ; Sat, 3 Dec 2022 01:11:02 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 5B4BD60003 for ; Fri, 2 Dec 2022 23:11:01 +0000 (UTC) Date: Sat, 3 Dec 2022 00:11:00 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221202231100.GW3806951@pb2> References: <20220911142721.30812-1-michael@niedermayer.cc> <20220911142721.30812-2-michael@niedermayer.cc> <20221201195600.GS3806951@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Fix overflow in k=31 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4479921511426109055==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4479921511426109055== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="csgZZokDzjk698W/" Content-Disposition: inline --csgZZokDzjk698W/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 02, 2022 at 05:14:58PM +0100, Paul B Mahol wrote: > On Thu, Dec 1, 2022 at 8:56 PM Michael Niedermayer > wrote: >=20 > > On Wed, Nov 30, 2022 at 09:39:44PM +0100, Paul B Mahol wrote: > > > On 9/11/22, Michael Niedermayer wrote: > > > > Untested with "non fuzzed" samples as i have no such file > > > > > > > > > > Then create it. > > > > the official WavPack-5.6.0 decoder has 2 alternative optimized codepath= es > > #ifdef USE_BITMASK_TABLES > > extras =3D bitset [bitcount] - maxcode - 1; > > #else > > extras =3D (1 << bitcount) - maxcode - 1; > > #endif > > > > The 2nd path would result in the same 1<<32 which is undefined but luck= ily > > the first seems hardcoded to be used it uses this table: > > > > const uint32_t bitset [] =3D { > > 1L << 0, 1L << 1, 1L << 2, 1L << 3, > > 1L << 4, 1L << 5, 1L << 6, 1L << 7, > > 1L << 8, 1L << 9, 1L << 10, 1L << 11, > > 1L << 12, 1L << 13, 1L << 14, 1L << 15, > > 1L << 16, 1L << 17, 1L << 18, 1L << 19, > > 1L << 20, 1L << 21, 1L << 22, 1L << 23, > > 1L << 24, 1L << 25, 1L << 26, 1L << 27, > > 1L << 28, 1L << 29, 1L << 30, 1L << 31 > > }; > > > > here bitset[32] is out of array > > > > Given above i suspect no valid file should use this. Otherwise something > > seriously odd is going on. > > > > also the subject has a typo its p=3D31 not k=3D31 > > > > thx > > >=20 > OK will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --csgZZokDzjk698W/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY4qF/QAKCRBhHseHBAsP qxWuAJ9AarfHgnNW70ytMgSyvOknZRmrVACdGXa3JjdVxmiNFDgu9vGtrxo8SaU= =D4Tv -----END PGP SIGNATURE----- --csgZZokDzjk698W/-- --===============4479921511426109055== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4479921511426109055==--