From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4612143977 for ; Fri, 2 Dec 2022 05:07:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 84F1968813B; Fri, 2 Dec 2022 07:07:07 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB58D6808C9 for ; Fri, 2 Dec 2022 07:07:00 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id B8786C0002 for ; Fri, 2 Dec 2022 05:06:59 +0000 (UTC) Date: Fri, 2 Dec 2022 06:06:58 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221202050658.GV3806951@pb2> References: <20221201081408.2194579-1-fei.w.wang@intel.com> <20221201081408.2194579-3-fei.w.wang@intel.com> <20221202002159.GT3806951@pb2> <33a5c599c7145eb0be192043c6eba0bc7acd6946.camel@intel.com> MIME-Version: 1.0 In-Reply-To: <33a5c599c7145eb0be192043c6eba0bc7acd6946.camel@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6520880618803458746==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6520880618803458746== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ByM1h5nouWwd3kz8" Content-Disposition: inline --ByM1h5nouWwd3kz8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 02, 2022 at 12:58:48AM +0000, Wang, Fei W wrote: > On Fri, 2022-12-02 at 01:21 +0100, Michael Niedermayer wrote: > > On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote: > > > From: Linjie Fu > > >=20 > > > 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC- > > > H.265-201911. > > > 2. Keep using parsed PPS when bitstream overread for compatibility. > > > For > > > example, the clip PS_A_VIDYO_3.bit in FATE test has incomplete > > > extension > > > syntax which will be overread and un-decodable if without this > > > change. > > > 3. Format brace in pps_range_extensions(). > > >=20 > > > Signed-off-by: Linjie Fu > > > Signed-off-by: Haihao Xiang > > > Signed-off-by: Fei Wang > > > --- > > > libavcodec/hevc.h | 3 + > > > libavcodec/hevc_ps.c | 293 > > > +++++++++++++++++++++++++++++++++++++++++-- > > > libavcodec/hevc_ps.h | 69 ++++++++++ > > > 3 files changed, 357 insertions(+), 8 deletions(-) > >=20 > > This causes segfaults > >=20 > > shortened stack trace looks like this,=20 > > seems like classic stack overflow from infinite recursion >=20 > Thanks Michael, Could you send me the clip caused this issue? file sent privatly thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. --ByM1h5nouWwd3kz8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY4mH8gAKCRBhHseHBAsP q7ouAJ9TyYeV/3kKcq+8pWfacgj4eWHQXgCeLyrAHbE51xicOHOUMycnpZQJni0= =9NSW -----END PGP SIGNATURE----- --ByM1h5nouWwd3kz8-- --===============6520880618803458746== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6520880618803458746==--