Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax
Date: Fri, 2 Dec 2022 06:06:58 +0100
Message-ID: <20221202050658.GV3806951@pb2> (raw)
In-Reply-To: <33a5c599c7145eb0be192043c6eba0bc7acd6946.camel@intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1678 bytes --]

On Fri, Dec 02, 2022 at 12:58:48AM +0000, Wang, Fei W wrote:
> On Fri, 2022-12-02 at 01:21 +0100, Michael Niedermayer wrote:
> > On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote:
> > > From: Linjie Fu <linjie.fu@intel.com>
> > > 
> > > 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC-
> > > H.265-201911.
> > > 2. Keep using parsed PPS when bitstream overread for compatibility.
> > > For
> > > example, the clip PS_A_VIDYO_3.bit in FATE test has incomplete
> > > extension
> > > syntax which will be overread and un-decodable if without this
> > > change.
> > > 3. Format brace in pps_range_extensions().
> > > 
> > > Signed-off-by: Linjie Fu <linjie.justin.fu@gmail.com>
> > > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > > Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> > > ---
> > >  libavcodec/hevc.h    |   3 +
> > >  libavcodec/hevc_ps.c | 293
> > > +++++++++++++++++++++++++++++++++++++++++--
> > >  libavcodec/hevc_ps.h |  69 ++++++++++
> > >  3 files changed, 357 insertions(+), 8 deletions(-)
> > 
> > This causes segfaults
> > 
> > shortened stack trace looks like this, 
> > seems like classic stack overflow from infinite recursion
> 
> Thanks Michael, Could you send me the clip caused this issue?

file sent privatly

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".