From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC93344895 for ; Fri, 2 Dec 2022 00:22:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6D679687FB9; Fri, 2 Dec 2022 02:22:08 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B3B84689956 for ; Fri, 2 Dec 2022 02:22:01 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id D71FBE0002 for ; Fri, 2 Dec 2022 00:22:00 +0000 (UTC) Date: Fri, 2 Dec 2022 01:21:59 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221202002159.GT3806951@pb2> References: <20221201081408.2194579-1-fei.w.wang@intel.com> <20221201081408.2194579-3-fei.w.wang@intel.com> MIME-Version: 1.0 In-Reply-To: <20221201081408.2194579-3-fei.w.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4508415077481650681==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4508415077481650681== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1Dvf9Qz7hFaodvwE" Content-Disposition: inline --1Dvf9Qz7hFaodvwE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote: > From: Linjie Fu >=20 > 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC-H.265-2= 01911. > 2. Keep using parsed PPS when bitstream overread for compatibility. For > example, the clip PS_A_VIDYO_3.bit in FATE test has incomplete extension > syntax which will be overread and un-decodable if without this change. > 3. Format brace in pps_range_extensions(). >=20 > Signed-off-by: Linjie Fu > Signed-off-by: Haihao Xiang > Signed-off-by: Fei Wang > --- > libavcodec/hevc.h | 3 + > libavcodec/hevc_ps.c | 293 +++++++++++++++++++++++++++++++++++++++++-- > libavcodec/hevc_ps.h | 69 ++++++++++ > 3 files changed, 357 insertions(+), 8 deletions(-) This causes segfaults shortened stack trace looks like this,=20 seems like classic stack overflow from infinite recursion #0 0x0000555556403d10 in colour_mapping_octants () #1 0x0000555556403d15 in colour_mapping_octants () #2 0x0000555556403d15 in colour_mapping_octants () #3 0x0000555556403d15 in colour_mapping_octants () #4 0x0000555556403d15 in colour_mapping_octants () #5 0x0000555556403d15 in colour_mapping_octants () #6 0x0000555556403d15 in colour_mapping_octants () #7 0x0000555556403d15 in colour_mapping_octants () #8 0x0000555556403d15 in colour_mapping_octants () #9 0x0000555556403d15 in colour_mapping_octants () #10 0x0000555556403d15 in colour_mapping_octants () #11 0x0000555556403d15 in colour_mapping_octants () #12 0x0000555556403d15 in colour_mapping_octants () =2E.. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras --1Dvf9Qz7hFaodvwE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY4lFIAAKCRBhHseHBAsP q77rAJ9knYGISppZoO8d5qyBg5OzCMX/QgCglDShHGtLuwtyE1FyAqekz9hpLXE= =p1mu -----END PGP SIGNATURE----- --1Dvf9Qz7hFaodvwE-- --===============4508415077481650681== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4508415077481650681==--