From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax
Date: Fri, 2 Dec 2022 01:21:59 +0100
Message-ID: <20221202002159.GT3806951@pb2> (raw)
In-Reply-To: <20221201081408.2194579-3-fei.w.wang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1942 bytes --]
On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote:
> From: Linjie Fu <linjie.fu@intel.com>
>
> 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC-H.265-201911.
> 2. Keep using parsed PPS when bitstream overread for compatibility. For
> example, the clip PS_A_VIDYO_3.bit in FATE test has incomplete extension
> syntax which will be overread and un-decodable if without this change.
> 3. Format brace in pps_range_extensions().
>
> Signed-off-by: Linjie Fu <linjie.justin.fu@gmail.com>
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
> libavcodec/hevc.h | 3 +
> libavcodec/hevc_ps.c | 293 +++++++++++++++++++++++++++++++++++++++++--
> libavcodec/hevc_ps.h | 69 ++++++++++
> 3 files changed, 357 insertions(+), 8 deletions(-)
This causes segfaults
shortened stack trace looks like this,
seems like classic stack overflow from infinite recursion
#0 0x0000555556403d10 in colour_mapping_octants ()
#1 0x0000555556403d15 in colour_mapping_octants ()
#2 0x0000555556403d15 in colour_mapping_octants ()
#3 0x0000555556403d15 in colour_mapping_octants ()
#4 0x0000555556403d15 in colour_mapping_octants ()
#5 0x0000555556403d15 in colour_mapping_octants ()
#6 0x0000555556403d15 in colour_mapping_octants ()
#7 0x0000555556403d15 in colour_mapping_octants ()
#8 0x0000555556403d15 in colour_mapping_octants ()
#9 0x0000555556403d15 in colour_mapping_octants ()
#10 0x0000555556403d15 in colour_mapping_octants ()
#11 0x0000555556403d15 in colour_mapping_octants ()
#12 0x0000555556403d15 in colour_mapping_octants ()
...
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-02 0:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 8:13 [FFmpeg-devel] [PATCH v1 01/13] lavc/hevc_ps: remove profile limitation of pps_range_extensions() Fei Wang
2022-12-01 8:13 ` [FFmpeg-devel] [PATCH v1 02/13] lavc/avcodec: Add HEVC Screen Content Coding Extensions profile Fei Wang
2022-12-01 8:13 ` [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax Fei Wang
2022-12-02 0:21 ` Michael Niedermayer [this message]
2022-12-02 0:58 ` Wang, Fei W
2022-12-02 5:06 ` Michael Niedermayer
2022-12-02 1:22 ` James Almer
2022-12-02 1:52 ` James Almer
2022-12-05 6:11 ` Wang, Fei W
2022-12-01 8:13 ` [FFmpeg-devel] [PATCH v1 04/13] lavc/hevcdec: Add slice parse support for HEVC SCC extension Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 05/13] lavc/hevcdec: Fix the parsing for use_integer_mv_flag Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 06/13] lavc/hevcdec: Set max_num_merge_cand to uint8_t Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 07/13] lavc/hevc: Update reference list for SCC Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 08/13] lavc/vaapi_hevc: Pass SCC parameters Through VA-API Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 09/13] lavc/vaapi_hevc: Add vaapi profile parse support for SCC Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 10/13] lavc/vaapi_hevc: Set correct rps type for scc Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 11/13] lavc/vaapi_hevc: Loose the restricts for SCC decoding Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 12/13] avcodec/hevcdec: Replace number with enum Fei Wang
2022-12-01 8:14 ` [FFmpeg-devel] [PATCH v1 13/13] lavc/vaapi_hevc: Remove duplicate code Fei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202002159.GT3806951@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git