Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pictordec: Remove mid exit branch
Date: Mon, 28 Nov 2022 20:56:24 +0100
Message-ID: <20221128195624.GM3806951@pb2> (raw)
In-Reply-To: <Y4FTJqx8o0K8cDmc@4eb231a0d1b36cedda43a2a005befe4d>


[-- Attachment #1.1: Type: text/plain, Size: 1394 bytes --]

On Sat, Nov 26, 2022 at 10:43:34AM +1100, Peter Ross wrote:
> On Fri, Nov 25, 2022 at 09:18:33PM +0100, Michael Niedermayer wrote:
> > This causes the RLE decoder to exit before applying the last RLE run
> > All images i tested with are unchanged, this makes the special case
> > for handling the last run unused for non truncated images.
> > 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/pictordec.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/libavcodec/pictordec.c b/libavcodec/pictordec.c
> > index 09229b94fd..27f5b96571 100644
> > --- a/libavcodec/pictordec.c
> > +++ b/libavcodec/pictordec.c
> > @@ -246,8 +246,6 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *frame,
> >                          run = bytestream2_get_le16(&s->g);
> >                      val = bytestream2_get_byte(&s->g);
> >                  }
> > -                if (!bytestream2_get_bytes_left(&s->g))
> > -                    break;
> >  
> >                  if (bits_per_plane == 8) {
> >                      picmemset_8bpp(s, frame, val, run, &x, &y);
> > -- 
> > 2.17.1
> 
> ok

will apply

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-11-28 19:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 20:18 Michael Niedermayer
2022-11-25 23:43 ` Peter Ross
2022-11-28 19:56   ` Michael Niedermayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221128195624.GM3806951@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git